feat(color): add semantic terminal coloring via color_mode config (#24)

[thomaschristory]

Summary

• Adds ColorMode StrEnum (auto|on|off) to config with defaults.color_mode: auto default
• Adds resolve_color() and color: bool to RuntimeContext; resolved once at bootstrap via sys.stdout.isatty()
• Semantic table cell coloring: status strings (active→green, failed→red, planned→yellow), booleans, and empty cells
• Colorizes delete success messages (deleted in yellow, already absent dimmed)
• color_mode: off suppresses all Rich markup including existing error/explain panels

Test Plan

• just test — 656 passed, 1 skipped
• just lint — ruff + mypy --strict clean
• Manual: nsc <resource> list in a TTY shows colored status cells
• Manual: nsc <resource> list | cat produces plain output (auto mode)
• Manual: set defaults.color_mode: off in config — no ANSI anywhere
• Manual: set defaults.color_mode: on — colors even when piped

Closes #24

🤖 Generated with Claude Code

[thomaschristory]

Code review

Found 1 issue:

1. make_console(color=True) does not disable Rich's auto-highlighter, causing unintended bold/style artifacts on plain strings. When color=True, the factory uses force_terminal=True but leaves highlight=True (the default). Rich's highlighter bolds parentheses, colorizes IP addresses, and applies other patterns to plain text — so (no records) renders as \x1b[1m(\x1b[0mno records\x1b[1m)\x1b[0m (bolded parens) and [dim]already absent (no change)[/] gets extra bold on the parens inside the dim span.

netbox-super-cli/nsc/output/_console.py

Lines 10 to 13 in bc56b2a

	def make_console(stream: TextIO, *, color: bool, soft_wrap: bool = False) -> Console:
	if color:
	return Console(file=stream, force_terminal=True, soft_wrap=soft_wrap)
	return Console(file=stream, no_color=True, highlight=False, soft_wrap=soft_wrap)

Fix: add highlight=False to the color=True branch:

def make_console(stream: TextIO, *, color: bool, soft_wrap: bool = False) -> Console:
    if color:
        return Console(file=stream, force_terminal=True, highlight=False, soft_wrap=soft_wrap)
    return Console(file=stream, no_color=True, highlight=False, soft_wrap=soft_wrap)

Verified against the live Rich library: plain console.print('(no records)') with force_terminal=True emits \x1b[1m(\x1b[0mno records\x1b[1m)\x1b[0m; adding highlight=False gives the expected clean (no records).

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[thomaschristory]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[thomaschristory]

Advisory findings (below confidence threshold)

These issues scored 75/100 — verified real but not certain enough to block. Flagged for awareness:

1. sys.stdout.isatty() used to gate color for both stdout and stderr — In color_mode: auto, piping stdout (e.g. nsc list | jq) sets color=False, silencing Rich error panels on stderr even though stderr is still a TTY. Reverse: redirecting stderr while stdout is a TTY leaks ANSI codes into the file.

netbox-super-cli/nsc/cli/globals.py

Lines 56 to 60 in bc56b2a

	debug=state.debug,
	page_size=state.config.defaults.page_size,
	color=resolve_color(state.config.defaults.color_mode, is_tty=sys.stdout.isatty()),
	)

2. API-sourced values passed unescaped into Rich markup strings — env.error, env.endpoint, and env.details come from HTTP responses and are interpolated directly into f"[bold red]{env.type.value}[/]: {env.error}". A server returning a value containing [ / ] can garble output or raise MarkupError. Same applies to _format_cell returning raw text when color=True.

netbox-super-cli/nsc/output/errors.py

Lines 103 to 121 in bc56b2a

	console = make_console(stream, color=color, soft_wrap=True)
	body_lines = [
	f"[bold red]{env.type.value}[/]: {env.error}",
	]
	if env.endpoint:
	body_lines.append(f"endpoint: {env.endpoint}")
	if env.method is not None:
	body_lines.append(f"method: {env.method.value}")
	if env.status_code is not None:
	body_lines.append(f"status: {env.status_code}")
	if env.operation_id:
	body_lines.append(f"op: {env.operation_id}")
	if env.attempt_n is not None:
	body_lines.append(f"attempt: {env.attempt_n}")
	if env.audit_log_path:
	body_lines.append(f"audit: {env.audit_log_path}")
	if env.details:
	body_lines.append(f"details: {env.details}")
	console.print(Panel("\n".join(body_lines), title="nsc error", border_style="red"))

https://github.com/thomaschristory/netbox-super-cli/blob/bc56b2a9b437326dcb5e380d1f6c36029f1d0e4e/nsc/output/table.py#L62-L80

3. make_console(color=True) omits highlight=False — The no-color path sets highlight=False but the color path does not, so Rich's auto-highlighter (numbers → magenta, URLs → blue) fires on top of intentional status markup.

https://github.com/thomaschristory/netbox-super-cli/blob/bc56b2a9b437326dcb5e380d1f6c36029f1d0e4e/nsc/output/_console.py#L10-L14

4. explain.py color path has no tests — render_to_rich_stdout gained color: bool = False but unlike errors.py (→ test_errors_color.py) and table.py (→ test_table_color.py), no test_explain_color.py was added. CLAUDE.md requires TDD.

netbox-super-cli/nsc/output/explain.py

Lines 153 to 156 in bc56b2a

	def render_to_rich_stdout(trace: ExplainTrace, *, stream: TextIO, color: bool = False) -> None:
	console = make_console(stream, color=color, soft_wrap=True)
	body = [

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[thomaschristory]

Picked up review fixes. Merged latest main (resolved conflicts in globals.py/errors.py/uv.lock), addressed all review feedback: highlight=False on color console, escape API/user text before Rich markup (table/errors/explain, both color modes), and split RuntimeContext.color_stderr from stdout color so 2>file no longer leaks ANSI. 668 tests pass, lint+mypy clean locally. Waiting on CI.