style: use canonical header names in Get/Set string literals - #83
Merged
Conversation
golangci-lint v2.13.2's canonicalheader recognizes ETag and WWW-Authenticate as initialism headers and flags "etag", "Etag", and "Www-Authenticate" literals. http.Header canonicalizes keys on every Get/Set, so behavior is unchanged; the literals now read the way the headers appear on the wire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header string literals passed to
http.HeaderGet, Set, and Values now spell ETag and WWW-Authenticate the way they appear on the wire, instead ofetag,Etag, andWww-Authenticate.http.Headercanonicalizes keys on every call, so runtime behavior is identical.This is the autofix golangci-lint v2.13.2's canonicalheader applies on CI, where it has been failing Lint on main since #81 landed. The linter does not report these sites when run against a Nix-built Go toolchain, which is why the hook passed locally before every merge today.