Open
Conversation
git-subtree-dir: src/snap git-subtree-split: 14b8845b0516a0a1a148331bb99b0a49558a8047
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the huge diff, I added snap as a git subtree with
You can update it at a later date with
This puts the entire source tree in the package, in this case we really only need the snap-core and glib-core directories and top-level makefiles, so you could add the rest to
.Rbuildignoreif you would like.Rather than putting the sources in
inst/I put them as a subdirectory ofsrc/, the former is only really useful if you are trying to expose the snap headers to other packages.Anyway hope this helps!