Skip to content

feat: addition of a button below existing one for the routing to the …#455

Merged
BrianDangDev merged 2 commits into
thoth-tech:Feature/Cross-Unitfrom
owens-hub-git:10.0.x
Apr 16, 2026
Merged

feat: addition of a button below existing one for the routing to the …#455
BrianDangDev merged 2 commits into
thoth-tech:Feature/Cross-Unitfrom
owens-hub-git:10.0.x

Conversation

@owens-hub-git
Copy link
Copy Markdown

@owens-hub-git owens-hub-git commented Apr 5, 2026

Description

Strict frontend change in the home component where I added a button underneath the current view all for previous units. This still routes to the same component for previous units, but will be the start for the cross-unit dashboard development

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Run the project locally.
  2. Opened the HomePage as a student
  3. Changing layouting for responsiveness and routing
  4. npm test locally

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Copy link
Copy Markdown

@cillynder cillynder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard button should be above the history button as it would generally be more important.

color="primary"
mat-fab
extended
aria-label="view all projects"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aria-label="view all projects"
aria-label="view previous projects"

extended
aria-label="view all projects"
>
<mat-icon style="color: white">history</mat-icon> View all
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<mat-icon style="color: white">history</mat-icon> View all
<mat-icon style="color: white">history</mat-icon> View previous

Should be changed so it's distinct from the other button.

Copy link
Copy Markdown

@cillynder cillynder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@owens-hub-git
Copy link
Copy Markdown
Author

@BrianDangDev
Could you please have a look at this PR to merge, Thankyou

@WaelAlahamdi
Copy link
Copy Markdown

Hi @owens-hub-git, I reviewed and tested the branch locally. It works well, but at the moment both buttons seem to go to the same page.
Based on the task, I expected the new button to open the dashboard. Could you please confirm whether this is the intended behaviour or if there is still another routing change to be added before approval?
Thanks.

@owens-hub-git
Copy link
Copy Markdown
Author

@WaelAlahamdi, This was mentioned in the description about what should happen when clicking the button as we are still working on the page to route to

Copy link
Copy Markdown

@WaelAlahamdi WaelAlahamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @owens-hub-git for clarifying. I reviewed and tested this locally, and it works as expected for the current scoped UI change. Approved based on the PR description.

@BrianDangDev
Copy link
Copy Markdown

Approved and Merged

@BrianDangDev BrianDangDev merged commit 8882396 into thoth-tech:Feature/Cross-Unit Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants