Add optimistic navigation for navigateTo#137
Open
jho406 wants to merge 1 commit intofix-scroll-restorationfrom
Open
Add optimistic navigation for navigateTo#137jho406 wants to merge 1 commit intofix-scroll-restorationfrom
navigateTo#137jho406 wants to merge 1 commit intofix-scroll-restorationfrom
Conversation
`navigateTo` requires a page to exist in the `pages` slice in order to successfully navigate. You would have to create a page in the store before calling `navigateTo`. The most common scenario is creating a copy of the current page with new params before navigating. e.g, facet filters. Its common enough that we add the ability to optimistically navigate. With these changes, you can provide a `search` hash that will get merged with the existing url query params. The page state is either copied over for history `push`s or moved to a new pageKey for history `replace`s before navigating. This also encourages folks to use the browser url to reflect application state, just like EmberJS instead of `useState`. For example: resolves #135 ``` const { navigateTo, pageKey, search } = useContext(NavigationContext) ```
jho406
force-pushed
the
add-optimistic-nav-options
branch
from
9c2d1a6 to
d05d912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
navigateTorequires a page to exist in thepagesslice in order to successfully navigate. You would have to create a page in the store before callingnavigateTo. The most common scenario is creating a copy of the current page with new params before navigating. e.g, facet filters.Its common enough that we add the ability to optimistically navigate. With these changes, you can provide a
searchhash that will get merged with the existing url query params. The page state is either copied over for historypushs or moved to a new pageKey for historyreplaces before navigating.This also encourages folks to use the browser url to reflect application state, just like EmberJS instead of
useState. For example:resolves #135