[pull] master from nodeca:master#18
Merged
Merged
Conversation
Integers at or above 1e21 (and Number.MAX_VALUE) stringify via Number.prototype.toString(10) in exponential notation, e.g. 1e21 -> "1e+21". The int tags identified these numbers (1e21 % 1 === 0) and represented them with that exponential text, producing output like `!!int '1e+21'`. That text matches no `!!int` resolution pattern, so loading the library's own dump output threw "cannot resolve a node with !<tag:yaml.org,2002:int> explicit tag". Per YAML 1.2.2 the Core (10.3) and JSON (10.2) `!!int` resolution accepts only [-+]?[0-9]+ (plus 0o/0x forms); exponential text is a float, not an int. Make the int tags reject numbers whose decimal stringification contains an exponent, and let the float tags claim them instead. The float `represent` already emits a valid float form (1.e+21) for such values, so they now round-trip. Restores the "numbers survive round-trip" invariant (#737) for large integers across the default, Core, JSON and YAML 1.1 schemas.
…rify round-trip test (ref #771)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )