Fix TabController disposal race during iOS scene-restore#1218
Open
zaelgohary wants to merge 1 commit intodevelopmentfrom
Open
Fix TabController disposal race during iOS scene-restore#1218zaelgohary wants to merge 1 commit intodevelopmentfrom
zaelgohary wants to merge 1 commit intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After completing phone/email verification on iOS, returning to the app via the SMS deep link can cause iOS to recreate the scene. Two HomeScreen instances briefly coexist: the new one assigns a fresh TabController to the global singleton in initState, then the old one's dispose runs and disposes whichever controller is currently in the global — including the new one. Tapping any home card after that hits a Null check on the disposed controller and freezes the UI.
Related Issue
Closes #1216
Changes
Test Results
Tested on iPhone (iOS 26.4.1) — phone verification flow completes, deep link returns to app, "Phone verified" dialog appears, home cards remain tappable.