Canonical and alternate links updated#1106
Open
yavuzyazici wants to merge 5 commits into
Open
Conversation
Member
|
Hi, thanks for reporting the issue and for the pull request. This isn't quite right though as it will produce extra Line 490 - change from: Lines 311 and 318 - add trailing slash: However we should also add some tests to make this stays fixed and also make sure it doesn't mess anything up. |
Author
|
Sorry for late reply. I was having busy days at office Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we check the website
All the URLs forwards to the version which has '/' at the end.
https://www.thunderbird.net/tr/donate => https://www.thunderbird.net/tr/donate/
So canonical tags and alternate URL addresses needs to be same with that. Some search engines are smart enought to understand that link difference. But some can't.
I thought to fix that from builder.py but i am not experienced enaught for this project. Maybe there is some consequences for canonical_path change