feat(docker): fall back to the GitHub release image when a registry i… - #7
Merged
Merged
Conversation
…s unreachable The agent-image pre-pull runs inside the Docker daemon, so it fails for ANY registry (Docker Hub, GHCR) when the daemon lives in a VM with no internet egress — e.g. a Colima/Lima VM whose virtual network a corporate VPN doesn't route. Retrying or switching registries can't help. Add a host-side fallback: the host (which does have network) downloads the image tarball from the GitHub release and `docker load`s it into the daemon over the socket, which needs no VM egress. - electron/ipc/docker-pull.ts: acquireAgentImage() fallback chain (cached -> docker pull -> GitHub-release download + docker load -> local build) plus downloadAndLoadReleaseImage() with sha256 verification and pinned->latest URL fallback - electron/ipc/pty.ts: wire the chain in for the default image; replace the terse pull error with a VM-egress diagnostic - .github/workflows/release.yml: build the agent image on native runners and attach per-arch forge-agent-<arch>.tar.gz + .sha256 to each release - docker-pull.test.ts: cover chain ordering, download, checksum mismatch, and 404->latest fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s unreachable
The agent-image pre-pull runs inside the Docker daemon, so it fails for ANY registry (Docker Hub, GHCR) when the daemon lives in a VM with no internet egress — e.g. a Colima/Lima VM whose virtual network a corporate VPN doesn't route. Retrying or switching registries can't help. Add a host-side fallback: the host (which does have network) downloads the image tarball from the GitHub release and
docker loads it into the daemon over the socket, which needs no VM egress.