feat(cli): add resvg-js CLI to @resvg/resvg-js#349
Open
feat(cli): add resvg-js CLI to @resvg/resvg-js#349
resvg-js CLI to @resvg/resvg-js#349Conversation
avoid file buffer being interrupted
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
I sincerely appreciate your contribution to the resvg-js ecosystem, but since this is a rust-oriented project, I'd like the CLI to be in a separate repository. I can add you to the |
Author
Thanks !!! and how do I publish to @resvg org or add @resvg team? |
Zhengqbbb
added a commit
to Zhengqbbb/resvg-js-cli
that referenced
this pull request
Aug 24, 2024
15dd771 to
34c1451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#348
I'm glad you can let me feel free do this work.
After some consideration, I think it would be more straightforward to directly include the CLI bundle file in the @resvg/resvg-js project and add a bin file. This way, CLI can directly use the core functions in ./index.js with the transform options:
yarn resvg-jsorpnpm resvg-js.I would like to hear your opinion. If you have any other ideas, feel free to tell me.
monorepo or create a new repo. IMO, placing it in the project as a separate file that can be called will not impact the main program's operation, and it will maintain uniformity in future maintenance and version control.
Next plan:
jsorts(I would like to hear your opinion. Initially, I found that index.js was written in JavaScript, but later the wasm was written in TypeScript.🫣)cli/option.js. ensure CLI options can be transformResvgOptionsI released a pre-release version for testing, welcome to experience it
bunx @qbbsh/resvg-js -h # or npx @qbbsh/resvg-js -hBase usage
base-usage.mp4
Advanced Usage
pipelinewith-imagemagick.mp4