harden: malformed-input hardening, non-panicking encoders, unit coverage - #443
Open
MattJackson wants to merge 2 commits into
Open
harden: malformed-input hardening, non-panicking encoders, unit coverage#443MattJackson wants to merge 2 commits into
MattJackson wants to merge 2 commits into
Conversation
MattJackson
changed the title
Contributor
Author
|
📌 Carrying over review feedback from the previous incarnation of this PR (#436), which is being closed in favour of a native stacked-PR chain. @victorchutw raised a still-open correctness issue on this branch — This is tracked and not yet addressed on this branch — flagging so it isn't lost in the migration. Thanks @victorchutw. |
This was referenced Sep 2, 2026
MattJackson
force-pushed
the
stack/s5
branch
from
September 2, 2026 19:34
3945747 to
f2d0a05
Compare
MattJackson
force-pushed
the
stack/s5
branch
2 times, most recently
from
September 2, 2026 20:24
036a4da to
a1854c6
Compare
MattJackson
force-pushed
the
stack/s5
branch
from
September 2, 2026 21:17
a1854c6 to
8725f5f
Compare
MattJackson
force-pushed
the
stack/s5
branch
3 times, most recently
from
September 2, 2026 23:54
2b83ba6 to
e9b8f48
Compare
MattJackson
force-pushed
the
stack/s5
branch
from
September 3, 2026 00:01
e9b8f48 to
0f2e408
Compare
MattJackson
force-pushed
the
stack/s5
branch
from
September 3, 2026 00:50
0f2e408 to
1e9d792
Compare
MattJackson
force-pushed
the
stack/s5
branch
from
September 3, 2026 01:10
1e9d792 to
15c7865
Compare
…erage across codec/tokens/config
- pre_login: comment claimed unknown tokens are skipped, but they are rejected as a protocol error (matching the existing test) — fix the comment - revert the 1<<0 -> 1 churn and drop the "shift-invariant" comments - trim mutation-testing narration comments across codec/token modules - remove "previously…" history comments (fixed_len, token_col_metadata, numeric) - sql_read_bytes: use std::pin::pin! instead of unsafe Pin::new_unchecked in a test
MattJackson
force-pushed
the
stack/s5
branch
from
September 3, 2026 15:05
4682dcc to
6065d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robustness hardening and broad unit-test coverage across the codec/token layer.
Squashed into a single commit (all the submitter's own work — no external authorship to preserve here).
Supersedes: none.
Sequential series — merge after #432–#435. Based on
main; diff reduces to its own delta as the earlier PRs land.Reviewer note: rebase-merge or merge-commit, not squash (keeps the series consistent).