Fix multi JWTs in headers check not running#139
Open
tera-si wants to merge 1 commit intoticarpi:masterfrom
Open
Fix multi JWTs in headers check not running#139tera-si wants to merge 1 commit intoticarpi:masterfrom
tera-si wants to merge 1 commit intoticarpi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition
if cookietoken[1] == 1 or headertoken[1] == 1 or posttoken[1]:checks that only one JWT is present in either the request cookies or headers. Any requests containing more than one token in the cookies or headers are rejected.Currently, even if multiple JWTs were submitted in the headers, such as:
The
headertoken[1] == 1check would still be satisfied and the scan would still proceed.This is because after the header substitution, the header counter is not updated. Changing this line
headertoken[1] = 1toheadertoken[1] += 1fixes that.Also by the same logic I believe it should be
posttoken[1] == 1in that condition? I haven't changed that yet as I'm not sure if that was the intention.