Fix For Password Archival And Expiration After rails-7 Upgrade

[rg-victorylive]

Jira: VP-2057

Important

Toggle to Squash and Merge when merging PRs to staging branch

What

• Fixnum was merged into Integer in newer Ruby versions. Rails 5 was lenient with this, but Rails 7 requires checking against Integer explicitly.
• Using is_a?(TrueClass) is not a reliable way to check for true. It caused logic to fail in Rails 7 that used to work in Rails 5.
• expire_password_after is usually a duration like 365.days, which isn’t a number. Rails 5 handled this loosely, but Rails 7 is stricter. Checking with respond_to?(:ago) ensures it behaves like a duration.

Testing

I tested this code by (unit/integration/manual) testing…

Extras

• Includes a DB migration
• After merge, requires local environment changes like running bin/build, .env changes etc.
• Includes UI Changes: add screenshots or videos

(if any are checked, please describe below)

PR Code Coverage

• Changeset: XX%
• Overall: XX%

Measure with bin/test_cov or some other means. You can find html coverage levels in coverage/index.html or in stdout.

After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana

[rg-victorylive]

Fixnum was merged into Integer in newer Ruby versions. Rails 5 was lenient with this, but Rails 7 requires checking against Integer explicitly.

[rg-victorylive]

expire_password_after is usually a duration like 365.days, which isn’t a number. Rails 5 handled this loosely, but Rails 7 is stricter. Checking with respond_to?(:ago) ensures it behaves like a duration.