TidalAPI: accept flexible create dry-run responses - #360
Draft
stefanmoro wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Server PR #1787 keeps resource-create
dryRunat 204 with no body while standardizing normal creates to 201 and non-create mutations to 200. A later server change may make createdryRunan ordinary successful 2xx, with an empty body or a minimal JSON:API document.Retrofit already accepts all successful 2xx responses and handles 204. This closes the 200/202 response-conversion gap without weakening typed create responses.
There are currently no first-party Android call sites for
artistsPostorappreciationsPost, but the shared SDK boundary needs to be forward-compatible before one is added.Verification
./gradlew :tidalapi:testDebugUnitTest :tidalapi:lint