Skip to content

Fix uppercase cl100k contraction matching #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikeeI wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix uppercase cl100k contraction matching #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions codec/regexp.gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Capture(index = 0, unindex = -1)
One(Ch = ')
Atomic
Alternate
Set(Set = [R-Tr-tſ])
Set(Set = [STstſ])
Concatenate
Set(Set = [Rr])
Set(Set = [Ee])
Expand Down Expand Up @@ -102,9 +102,9 @@ func splitRegexp_Execute(r *regexp2.Runner) error {
alternation_starting_pos1 = pos

// Branch 0
// Node: Set(Set = [R-Tr-tſ])
// Match [R-Tr-tſ].
if len(slice) < 2 || ((slice[1] >= 128 || !helpers.IsInASCIIBitmap(slice[1], 0x0, 0x1c0000001c0000)) && (slice[1] < 128 || !set_4a1357005dba18ced5af0bde8202a98fab7a3500c675e3cb1c60597d7a36436a.CharIn(slice[1]))) {
// Node: Set(Set = [STstſ])
// Match [STstſ].
if len(slice) < 2 || ((slice[1] >= 128 || !helpers.IsInASCIIBitmap(slice[1], 0x0, 0x18000000180000)) && (slice[1] < 128 || !set_4a1357005dba18ced5af0bde8202a98fab7a3500c675e3cb1c60597d7a36436a.CharIn(slice[1]))) {
goto AlternationBranch1
}

Expand Down
1 change: 1 addition & 0 deletions tokenizer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func TestCl100kBase(t *testing.T) {
{text: "hello world", ids: []uint{15339, 256, 1917}},
{text: "supercalifragilistic", ids: []uint{13066, 3035, 278, 333, 4193, 321, 4633}},
{text: "We know what we are, but know not what we may be.", ids: []uint{1687, 1440, 1148, 584, 527, 11, 719, 1440, 539, 1148, 584, 1253, 387, 13}},
{text: "'RE", ids: []uint{95253}},
}

runTests(t, tok, tests)
Expand Down