Skip to content

support pre-generate bindings for aarch64#435

Merged
Connor1996 merged 13 commits into
tikv:masterfrom
glorv:aarch-bindgen
Mar 6, 2020
Merged

support pre-generate bindings for aarch64#435
Connor1996 merged 13 commits into
tikv:masterfrom
glorv:aarch-bindgen

Conversation

@glorv

@glorv glorv commented Feb 20, 2020

Copy link
Copy Markdown

in #402 we already support pre-generate bindings for x64_64, this pr add support for aarch64

Signed-off-by: glorv glorvs@163.com

Signed-off-by: glorv <glorvs@163.com>
@Connor1996

Copy link
Copy Markdown
Member

Sorry, we have no plan to pre-generate bindings for aarch64. It's fine for generating it when building.

@glorv

glorv commented Feb 20, 2020

Copy link
Copy Markdown
Author

Sorry, we have no plan to pre-generate bindings for aarch64. It's fine for generating it when building.

From v4.0, we need to support aarch64 platform, so it's make sense to use pre-generated bindings to make compilation easily. In cenos7 with aarch64 cpu, the raw bind-gen need newer version of clang (>6) which isn't provided in most case. So I think we should support this feature.

Signed-off-by: glorv <glorvs@163.com>
glorv added 11 commits February 20, 2020 18:42
…contain enough components for aarch64

Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>

@Connor1996 Connor1996 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glorv

glorv commented Mar 6, 2020

Copy link
Copy Markdown
Author

@yiwu-arbug PTAL

@overvenus overvenus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Connor1996
Connor1996 merged commit 74299c3 into tikv:master Mar 6, 2020
yiwu-arbug pushed a commit that referenced this pull request Mar 20, 2020
* add pre generated binding for aarch64

Signed-off-by: glorv <glorvs@163.com>
@glorv
glorv deleted the aarch-bindgen branch August 19, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants