chore: close Workflow v2 epic release gates - #38
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31c6c02ee9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| `STATE.md`, `FINAL_QUALITY_GATES.md`, and `REVIEW_REPORT.md` are generated projections of authoritative machine state. They are deterministic human-readable evidence, not lifecycle or review authority. Handwritten range audits or edits to generated Markdown must never be used to manufacture PASS coverage or completion. When authoritative state changes, regenerate the projections through the normal review-report/finalize paths. | ||
|
|
||
| Repository contributors and Git-backed book workflows should follow `docs/COMMIT_DISCIPLINE.md` for audit-friendly commit boundaries, provenance, and revert/recovery behavior. That document governs Git history as a secondary audit trail; it does not replace the machine-state acceptance rules in this orchestration contract. |
There was a problem hiding this comment.
For repository-API or namespaced installations that copy only the documented runtime set, docs/COMMIT_DISCIPLINE.md is absent because docs/AGENT_SETUP.md classifies it as development-only, yet this orchestrator contract directs Git-backed book workflows to follow it. Those supported installations therefore cannot access the referenced recovery and history guidance; either include the file in the runtime set or limit this direction to development checkouts.
AGENTS.md reference: AGENTS.md:L40-L44
Useful? React with 👍 / 👎.
| workflows = sorted(path.name for path in workflow_dir.glob("*.yml")) | ||
| self.assertEqual(workflows, ["tests.yml"]) |
There was a problem hiding this comment.
If an orchestration Action is added with GitHub's supported .yaml suffix, this test ignores it and still passes as long as tests.yml remains present, so the asserted “only generic optional CI workflow remains” gate does not enforce its stated policy. Collect both *.yml and *.yaml workflows before comparing the directory contents.
Useful? React with 👍 / 👎.
1 participant
Epic #20 closeout gate
Post-release closeout from
main@b67399ff03dcaafb917123b6b0e11212d3583462.Scope is intentionally limited to:
resume -> translator claim/acceptance -> reviewer evidence/promotion -> generated review report -> finalize -> validate/verify -> EPUB build/status;No production runtime files are changed.
RED -> GREEN evidence
RED:
492331b154788ec65b8403e45c9051b0469badc934292630701docs/COMMIT_DISCIPLINE.mdGREEN:
31c6c02ee98a2a59862261e4af4bf0f4a8bc30ba34293033405, conclusionsuccess102283541487: 327/327 OK102283541387: 327/327 OK598be206aa225b53ce4ebdbb0b5b169d2392f78f= exact head merged into the reviewed base.Dogfood gate
The new representative test creates a fresh two-chapter workspace and exercises the real CLI/runtime through:
accept-translation;accept-review;REVIEW_REPORT.mdwith 100% current PASS coverage and no stale/missing units;STATE.mdandFINAL_QUALITY_GATES.md;resumereporting complete;build-status=current..github/workflows/contains only the generic optionaltests.yml; runtime orchestration has no GitHub Actions dependency.Diff boundary
Only four files differ from base:
docs/AGENT_SETUP.mddocs/COMMIT_DISCIPLINE.mddocs/ORCHESTRATION.mdtests/test_workflow_v2_epic_closeout.pyNo deploy is part of this PR. PR #36 remains a historical non-merge CI harness.