This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Self containment of JS controller forms toolbars#275
Open
github-actions[bot] wants to merge 1 commit intomasterfrom
Open
Self containment of JS controller forms toolbars#275github-actions[bot] wants to merge 1 commit intomasterfrom
github-actions[bot] wants to merge 1 commit intomasterfrom
Conversation
ercanozkaya
approved these changes
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
Test Instructions
This fix can be tested on DOCman for Wordpress by simply adding a page block with a submit block (fragment) within the same WP page. Without the fix Kodekit ends up picking up the wrong toolbar (Submit button won't work) for each JS controller (more information on #274). With the fix, each toolbar is properly set.