If the remote repository returns a 200 response header but does not return any data and hangs the connection, it will cause thread exhaustion#13
Open
zwc456baby wants to merge 7 commits intotimboudreau:masterfrom
Conversation
Author
|
DownloaderV2A adds @singleton annotation, otherwise the failedURLs cache will be invalidated. |
|
@timboudreau any chance this will get considered? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the network connection request succeeds, but the remote end hangs and never returns data, the thread will hang and eventually the thread will be exhausted and unable to process requests. Try using a 15-minute timeout to fix this.