Skip to content

侧栏导航 + TitleBar 设置 + 桌面快捷方式 - #2

Merged
timeroute merged 1 commit into
mainfrom
cursor/windows-only-packaging-dd67
Oct 10, 2026
Merged

timeroute merged 1 commit into
mainfrom
cursor/windows-only-packaging-dd67

Conversation

@timeroute

@timeroute timeroute commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

变更

  1. 导航:去掉 TitleBar 上的 Tab 菜单,只保留侧栏
  2. 设置:TitleBar 右侧齿轮按钮进入设置页(侧栏不再放设置项)
  3. 安装包:提交 wix/main.wxs + wix/Product.ico
    • 安装后创建桌面与开始菜单快捷方式(带图标)
    • 不再写入 PATH(不依赖命令行启动)

说明

已基于合并后的 main(PR #1 squash)重放本变更,消除冲突。

Open in Web Open in Cursor 

@timeroute
timeroute marked this pull request as ready for review October 10, 2026 06:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T06:48:03.974421Z a84e2dd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Remove TitleBar tabs; open Settings from a titlebar gear button.
Ship WiX MSI with Start Menu + Desktop shortcuts and product icon,
without adding the install dir to PATH.

Rebased onto main after PR #1 squash-merge to clear conflicts.

Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
@cursor
cursor Bot force-pushed the cursor/windows-only-packaging-dd67 branch from a84e2dd to 50fabf2 Compare October 10, 2026 06:46
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

- name: Ensure WiX Toolset
shell: pwsh
run: |
function Add-WixToPath {
$wixBins = Get-ChildItem -Path @(
"${env:ProgramFiles(x86)}\WiX Toolset*\bin",

P1 Badge Add the actual WiX bin directory to PATH

Get-ChildItem on a path ending in \bin enumerates that directory's contents; with -Directory, this collects only subdirectories inside WiX's bin folder, not the bin folder that contains candle.exe and light.exe. Thus a preinstalled WiX Toolset that is not already on PATH is never discovered, and the later command check aborts the MSI workflow before cargo wix runs. Select the matched ...\WiX Toolset*\bin items themselves (for example with Get-Item) before appending them to PATH.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@timeroute
timeroute merged commit 867ab2c into main Oct 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants