Repository navigation
feat: integrate timeroute/wslc-rs fork + native container logs - #5
Merged
Merged
Conversation
Switch from vendored path dep to git pin on the fork tip; wire Container::logs(LogsOptions) instead of exec log scraping. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Pin timeroute/wslc-rs @ 9fbcd72 (merged retryable Sdk::load). Remove obsolete patches/wslc-sys-sdk-load-retryable.patch. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
timeroute
marked this pull request as ready for review
October 10, 2026 12:35
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop vendoring
wslc-rsand depend on the maintained forktimeroute/wslc-rsvia a pinned gitrev. Wire container Logs through the fork’sLogsOptionsAPI.Changes
Cargo.toml:wslc = { git = "https://github.com/timeroute/wslc-rs", rev = "9fbcd72…" }(includes mergedSdk::loadretry fix from fork PR 修复：空控制台窗口 + TitleBar 设置按钮无响应 #3)vendor/wslc-rs/live.rs:Container::logs(LogsOptions::new().tail(200).timestamps(true))instead of exec log-file scrapingrevafter your patchesNotes
wslc --session <name> container logs(C SDK has no Logs export yet). Requireswslc.exeon PATH (orWSLC_CLI_PATH). Uses the desktop session namewslc-desktop.followin the UI path (sync call would hang).Test plan
cargo teston Linux agent