Repository navigation
fix(msi): same-version install replaces previous product - #6
Merged
Merged
Conversation
Product Id=* regenerates ProductCode every build while Cargo version stays 0.1.0; without AllowSameVersionUpgrades MSI installs a second product. Enable same-version replace. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
timeroute
marked this pull request as ready for review
October 10, 2026 12:40
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repeated MSI installs were creating multiple “WSLc Desktop” entries in Apps & Features because each
cargo wixbuild gets a newProductCode(Id='*') whileVersionstayed0.1.0, andMajorUpgradedid not treat same-version as an upgrade.Fix
Set
AllowSameVersionUpgrades='yes'onMajorUpgradeso a newer MSI with the same UpgradeCode replaces the previous install even when the first three version fields are unchanged.Note for already-duplicated machines
This only affects new installs of the fixed MSI. Existing duplicate ARP entries should be uninstalled manually once, then install the new MSI.
Test plan
0.1.0, new build) → only one Apps & Features entry remains