Static site generation for GitHub pages #18
Conversation
chrishutchinson
requested review from
basilesimon,
elliotdavies and
flashcheeks
|
Aside from the technicalities, and I hate to be that guy, but are you going to have some of this designed at all, @chrishutchinson? It looks odd to me, like with a few things slightly off. |
|
@basilesimon Agree entirely. I will be putting it past Matt M as we did with the data vis catalogue before merging and releasing, but wanted overall agreement from the team on the tech side first |
elliotdavies
left a comment
elliotdavies
left a comment
There was a problem hiding this comment.
Overall approach looks great to me
| @@ -0,0 +1,84 @@ | |||
| const React = require("react"); | |||
| const ReactMarkdown = require("react-markdown"); | |||
There was a problem hiding this comment.
Don't think we've discussed as a team what our default prettier settings should be – the EB version (i.e. single quotes, trailing commas) or the tool defaults? Either way we should maybe add a .pretterrc to this repo
There was a problem hiding this comment.
Oh sorry, I totally meant to add one - I'll do that
| const ReactMarkdown = require("react-markdown"); | ||
|
|
||
| const capitalise = string => { | ||
| if (string === "aws") return string.toUpperCase(); |
There was a problem hiding this comment.
In terms of future-proofing, this could be an array of names?
There was a problem hiding this comment.
Good shout, will do
| @@ -0,0 +1,19 @@ | |||
| <html> | |||
| <head> | |||
| <title>Learning!</title> | |||
| name: a, | ||
| content, | ||
| headline: content.match(/# \[(.*?)\]/)[1], | ||
| dateAdded: fs.statSync(`${path}${a}`).birthtime |
There was a problem hiding this comment.
Seemed the most appropriate from this list
| if (diff === 0) return diff; | ||
| return diff > 0 ? -1 : 1; | ||
| }) | ||
| .splice(0, 3); |
There was a problem hiding this comment.
It's fine, honestly, but technically splice is a mutation
There was a problem hiding this comment.
Damn, I think I meant slice
| @@ -0,0 +1,282 @@ | |||
| html { | |||
| font-size: 62.5%; | |||
| text-rendering: optimizeLegibility; | |||
There was a problem hiding this comment.
What's this? Looks cool
There was a problem hiding this comment.
Honestly, I googled the best way to do full cross browser font smoothing. I suspect this covers a weird Windows case or something similar
| div.wrapper { | ||
| } | ||
|
|
||
| @media screen and (min-width: 737px) { |
There was a problem hiding this comment.
Same media query as the one above?
| display: block; | ||
| border-radius: 4px; | ||
| box-shadow: 0px 1px 1px #888; | ||
| } |
There was a problem hiding this comment.
Worth using SASS in this file, I think
There was a problem hiding this comment.
Yeah - I didn't really want to have to build a whole SASS thing, but now I've written it I think it's worth the investment
This PR adds:
index.htmlfile, which we can host on GitHub pagesREADMEin favour of the static site