HOK-1592_c: Prefix task-specific log lines with task ID#562
Closed
timogilvie wants to merge 3 commits intoauto/integrationfrom
Closed
HOK-1592_c: Prefix task-specific log lines with task ID#562timogilvie wants to merge 3 commits intoauto/integrationfrom
timogilvie wants to merge 3 commits intoauto/integrationfrom
Conversation
Add wavemill_format_task_log_message() to wavemill-common.sh: trims leading whitespace, prepends [ISSUE] when a task ID is known (via explicit --issue flag or WAVEMILL_ISSUE env), and deduplicates existing leading bracket/arrow tokens so the prefix is never doubled. Update both log() definitions in wavemill-mill.sh (main + monitor heredoc) to accept an optional --issue <id> flag that is passed at task-scoped call sites. Convert all task-specific call sites to use --issue and remove the inline $ISSUE token from message bodies. Update command-side log() wrappers in wavemill-plan.sh, wavemill-review.sh, wavemill-context.sh, and wavemill-expand.sh to call the shared formatter via implicit WAVEMILL_ISSUE. ERROR and WARN output remains unconditionally unprefixed. Add tests/log-prefix-task-id.test.sh covering formatter edge cases and mill log() integration. Wire into tests/check-shell.sh. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Change log level from invalid "warn" to "status" in handle_phase_launch_result.
Owner
Author
|
Closed as superseded by primary HOK-1592 implementation in PR #560, which merged into auto/integration on 2026-05-07. This challenger branch continued after the primary merged, conflicted with it, and is now failing CI, so it should not remain in the merge queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wavemill_format_task_log_messagehelper inwavemill-common.shthat prefixes log messages with[ISSUE_ID]when an issue is in context, stripping duplicate inlineISSUE →arrowswavemill-mill.sh,wavemill-context.sh,wavemill-expand.sh,wavemill-plan.sh, andwavemill-review.shto pass--issueso the prefix is appliedlog_error/log_warn) unprefixed so they remain visually distinct in the logging panetests/log-prefix-task-id.test.sh) validating prefix insertion, deduplication, and error/warn exemptionChanges
shared/lib/wavemill-common.sh— newwavemill_format_task_log_messagefunction and updatedlog()to accept--issueflagshared/lib/wavemill-mill.sh— updated phase-launch, retry, and status log calls to pass--issue; fixed invalidlog "warn"level tolog "status"inhandle_phase_launch_resultshared/lib/wavemill-context.sh— updated context-related log calls with--issueshared/lib/wavemill-expand.sh— updated expansion log calls with--issueshared/lib/wavemill-plan.sh— updated plan log calls with--issueshared/lib/wavemill-review.sh— updated review log calls with--issuetests/check-shell.sh— registers new test filetests/log-prefix-task-id.test.sh— new test file for log prefix behaviorTest plan
tests/log-prefix-task-id.test.shcovers: prefix insertion with--issue, no prefix without--issue, deduplication of inlineISSUE →arrows, and thatlog_error/log_warnremain unprefixedbash tests/check-shell.shSelf-review
log "warn"is not a valid log level;--issueflag was never parsed, producing garbled output inhandle_phase_launch_result. Fixed by changing tolog "status".Closes HOK-1592_c