HOK-1599: Fix needs-triage filtering, dedupe, and newline formatting#572
Merged
timogilvie merged 1 commit intoauto/integrationfrom May 8, 2026
Merged
Conversation
dcff3c0 to
e82190d
Compare
Owner
Author
Wavemill Merge failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rendered_idsassociative array (case-insensitive) so each task ID is only rendered once across all sections, preventing the same issue from appearing multiple timessection_body+=$(printf ...)withsection_body+="$(printf ...)"$'\n'— the subshell form strips trailing newlines, causing items to concatenate onto one lineChanges
shared/lib/plan-queue-utils.ts— UpdatedbuildQueuePlanto filterunknown_endpoint/depends_ontriage records where the blocking task is external; promotes those external blockers into the queue plan's ancestor list insteadshared/lib/wavemill-mill.sh— Addedrendered_idsdeduplication guard and fixed newline concatenation inrender_grouped_task_listfor all four display sections (available now, queued, conflict clusters, needs triage)tests/task-selection-renderer.test.sh— Tests updated to cover the new filtering and deduplication behaviortools/plan-queue.test.ts— Unit tests updated for the updatedbuildQueuePlanlogicTest plan
tools/plan-queue.test.tscover the external-blocker filtering logictests/task-selection-renderer.test.shcover deduplication and newline formattingSelf-review
Review tool exited with code 2 (transient Claude CLI failure —
claude CLI exited with code 1). Tool and base branch confirmed present; failure is an infrastructure issue unrelated to the diff.