Performance optimization for large matrices#85
Open
vagmcs wants to merge 1 commit intotimothyb0912:developfrom
Open
Performance optimization for large matrices#85vagmcs wants to merge 1 commit intotimothyb0912:developfrom
vagmcs wants to merge 1 commit intotimothyb0912:developfrom
Conversation
- In case weights given for calculating the weighted log-likelihood are none or ones, then there is no need to perform the multiplication and max operations over the rows_to_obs matrix, since it can lead to an out of memory error for very large matrices. Instead just set weights_per_obs to an array of ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computes
weghts_per_obsonly when requiredweightsgiven for calculating the weighted log-likelihood are none or ones, then there is no need to perform the multiplication and max operations over therows_to_obsmatrix, since it can lead to an out of memory error for very large matrices. Instead, just setweights_per_obsto an array of ones.