Skip to content

Update nonstationary#118

Open
timsainb wants to merge 4 commits into
masterfrom
update_nonstationary
Open

Update nonstationary#118
timsainb wants to merge 4 commits into
masterfrom
update_nonstationary

Conversation

@timsainb

@timsainb timsainb commented Nov 9, 2024

Copy link
Copy Markdown
Owner

Updates nonstationary version of algorithm to be more uniform with stationary version, by using moving mean + std to do noise thresholding.

This will create a small breaking change for current pipelines, since the parameters for the nonstationry have now switched.
mainly, n_std_thresh_stationary is now n_std_thresh, and shared across stationary and nonstationary.

@timsainb timsainb requested a review from nuniz November 9, 2024 11:37
@nuniz

nuniz commented Nov 9, 2024

Copy link
Copy Markdown
Collaborator

Hi Tim
If we're planning non-backwards compatible changes, we should also think about other updates for version 4, like adding the TensorFlow implementation or a refactor I've been thinking about.

How about we create a branch for version 4 and discuss this later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants