fix: add days (d) unit support to parse_duration (fixes #1)#52
Open
jiangyj545 wants to merge 1 commit into
Open
fix: add days (d) unit support to parse_duration (fixes #1)#52jiangyj545 wants to merge 1 commit into
jiangyj545 wants to merge 1 commit into
Conversation
The _UNITS dict was missing 'd' entry despite the regex _TOKEN already matching it. Added "d": 86400 to _UNITS and tests for days support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
parse_durationfunction silently dropped thed(days) unit because the_UNITSdict was missing the entry, even though the regex_TOKENalready matched it.Changes
"d": 86400to the_UNITSdict induration_utils.pytest_daysandtest_days_combinedVerification
All 9 tests pass (7 original + 2 new).
Fixes #1