fix: add days (d) unit support to parse_duration#69
Open
thanhle74 wants to merge 1 commit into
Open
Conversation
The regex pattern matches 'd' but _UNITS dict was missing the days
entry, causing parse_duration('1d') to return 0 instead of 86400.
Fixes tine1117#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The regex pattern
r"(\d+)([wdhms])"matchesdbut the_UNITSdict was missing the days entry, causingparse_duration("1d")to return 0 instead of 86400.Changes
"d": 86400to_UNITSdictTest Results
All 12 tests pass (including new day tests).
Fixes #1