Skip to content

fix: rebind to ldap svc account after pw check fail #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveiliop56 merged 3 commits into from
Oct 1, 2026
Merged

fix: rebind to ldap svc account after pw check fail #1165

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f407e64
fix: rebind to ldap svc account after pw check fail
steveiliop56 Sep 28, 2026
018ce6c
fix: rabbit comments
steveiliop56 Sep 28, 2026
2be70ba
fix: always rebind to svc account
steveiliop56 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions internal/service/auth_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (auth *AuthService) SearchUser(username string) (*model.UserSearch, error)
return nil, ErrUserNotFound
}

func (auth *AuthService) CheckUserPassword(search model.UserSearch, password string) error {
func (auth *AuthService) CheckUserPassword(search model.UserSearch, password string) (err error) {
switch search.Type {
case model.UserLocal:
user := auth.GetLocalUser(search.Username)
Expand All @@ -203,14 +203,20 @@ func (auth *AuthService) CheckUserPassword(search model.UserSearch, password str
return bcrypt.CompareHashAndPassword([]byte(user.Password), []byte(password))
case model.UserLDAP:
if auth.ldap != nil {
err := auth.ldap.Bind(search.Username, password)
if err != nil {
return fmt.Errorf("failed to bind to ldap user: %w", err)
}
defer func() {
bindErr := auth.ldap.BindService(true)
if bindErr != nil {
if err != nil {
err = fmt.Errorf("failed to rebind to ldap service account: %w, original error: %w", bindErr, err)
return
}
err = fmt.Errorf("failed to rebind to ldap service account: %w", bindErr)
}
}()

err = auth.ldap.BindService(true)
err = auth.ldap.Bind(search.Username, password)
if err != nil {
return fmt.Errorf("failed to bind to ldap service account: %w", err)
return fmt.Errorf("failed to bind to ldap user: %w", err)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

return nil
Expand Down
Loading