-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/74 앱 배포를 위한 설정 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
The head ref may contain hidden characters: "feat/74-\uC571-\uBC30\uD3EC\uB97C-\uC704\uD55C-\uC124\uC815"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR configures the TinyBite app for Android internal testing on Google Play Console. The main changes include adding environment variable management support, adjusting project versioning, and updating build configurations.
Key Changes:
- Added dotenv package for environment variable management and integrated it into app.config.js
- Downgraded project version from 1.0.0 to 0.1.0 to align with the current development stage
- Downgraded react-native-pager-view from 7.0.2 to 6.9.1 for compatibility/stability
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TinyBite/package.json | Added dotenv dependency, downgraded react-native-pager-view version, and updated project version to 0.1.0 |
| TinyBite/package-lock.json | Updated lockfile to reflect package.json changes with new dependency versions |
| TinyBite/eas.json | Configured Android production builds to use app-bundle build type for Play Store deployment |
| TinyBite/app.config.js | Added dotenv configuration at the top and updated project version to 0.1.0 |
| TinyBite/.gitignore | Modified iOS and Android directory ignore patterns from leading slash to trailing slash format |
| TinyBite/.vscode/settings.json | Added Java-related VS Code configuration for null analysis and build configuration updates |
| TinyBite/assets/images/icon.png | Updated application icon (binary file) |
Files not reviewed (1)
- TinyBite/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| require("dotenv").config(); | ||
|
|
Copilot
AI
Dec 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotenv.config() call is unnecessary in this context. Expo automatically loads environment variables prefixed with EXPO_PUBLIC_ from .env files. The existing code only uses process.env.EXPO_PUBLIC_* variables (lines 43, 63, 64), which Expo handles natively without requiring the dotenv package. Consider removing the dotenv dependency and this config call unless you plan to use non-EXPO_PUBLIC_ prefixed environment variables.
| require("dotenv").config(); |
| ios/ | ||
| android/ |
Copilot
AI
Dec 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gitignore pattern change from /ios and /android to ios/ and android/ alters the matching behavior. The leading slash /ios matches only the ios directory at the repository root, while ios/ (with trailing slash) matches any directory named ios at any level in the repository. If you only want to ignore the root-level ios and android directories (which is typical for React Native/Expo projects), the original /ios and /android patterns were correct. Consider reverting to the original patterns with leading slashes.
| ios/ | |
| android/ | |
| /ios | |
| /android |
⚙️ Related ISSUE Number
#74
📄 Work Description
google play console에서 안드로이드 내부 테스트를 위한 설정을 했습니다.
앱 전체에서 환경 변수를 로드할 수 있도록 app.config.js에서 이를 호출하도록 설정
새로운 개발 단계에 맞춰 일관성을 유지하기 위해 package.json, package-lock.json 및 app.config.js에서 프로젝트 버전을 1.0.0에서 0.1.0으로 업데이트
호환성 또는 안정성 문제를 해결하기 위해 package.json 및 package-lock.json 모두에서 react-native-pager-view 버전을 7.0.2에서 6.9.1로 다운그레이드
안드로이드 프로덕션 빌드 시 app-bundle 빌드 유형을 사용하도록 eas.json을 업데이트
📷 Screenshot
💬 To Reviewers
🔗 Reference