Flaky / order-dependent — blocks the diff-scoped Rust Core Coverage lane for any PR that adds a builtin agent.
openhuman::agent::harness::session::turn::tests::dedicated_profile_experience_recall_merges_shared_legacy_store (turn_tests.rs:2163) intermittently fails assert!(enriched.contains("Legacy shared deployment guidance")).
Non-deterministic: passes on main's full CI and passed on the first run of #5205, but failed on two subsequent runs of the same commit. The test uses locally-constructed dedicated/shared memory instances (not the global singleton), so the flakiness comes from some other shared process state exposed when the diff-coverage subset (-p openhuman --lib -- 'openhuman::agent' 'openhuman::agent_registry' 'openhuman::flows') runs that scope's tests together.
Repo-wide friction: any PR adding a builtin agent must edit agent/harness/definition_tests.rs (the exhaustive (id, max_iterations) audit), which pulls openhuman::agent into the diff-coverage scope — so this flake gates every agent-adding PR (surfaced by #5205).
Fix: identify the shared state inject_agent_experience_context / experience recall depends on and isolate it per-test (mirroring the FlowRunDigestSubscriber with_memory DI fix in #5176). Likely a global embedder/config or a shared experience-store path.
Impact now: blocks #5205's coverage gate despite that PR touching none of this code.
Flaky / order-dependent — blocks the diff-scoped Rust Core Coverage lane for any PR that adds a builtin agent.
openhuman::agent::harness::session::turn::tests::dedicated_profile_experience_recall_merges_shared_legacy_store(turn_tests.rs:2163) intermittently failsassert!(enriched.contains("Legacy shared deployment guidance")).Non-deterministic: passes on main's full CI and passed on the first run of #5205, but failed on two subsequent runs of the same commit. The test uses locally-constructed
dedicated/sharedmemory instances (not the global singleton), so the flakiness comes from some other shared process state exposed when the diff-coverage subset (-p openhuman --lib -- 'openhuman::agent' 'openhuman::agent_registry' 'openhuman::flows') runs that scope's tests together.Repo-wide friction: any PR adding a builtin agent must edit
agent/harness/definition_tests.rs(the exhaustive(id, max_iterations)audit), which pullsopenhuman::agentinto the diff-coverage scope — so this flake gates every agent-adding PR (surfaced by #5205).Fix: identify the shared state
inject_agent_experience_context/ experience recall depends on and isolate it per-test (mirroring the FlowRunDigestSubscriberwith_memoryDI fix in #5176). Likely a global embedder/config or a shared experience-store path.Impact now: blocks #5205's coverage gate despite that PR touching none of this code.