Skip to content

core/jsonrpc: make DomainGroup subscriber registration retryable #5269

Description

@graycyrus

From #5265 review (CodeRabbit Major). register_domain_subscribers marks a DomainGroup done the moment its group_first_time(…) block is entered, not after every subscribe_global inside returns Some. A transient failure (global bus not yet initialized) only logs a warning but the group is marked done, so no later call retries — that subscriber stays absent for the process lifetime. Pre-existing pattern at every group_first_time(DomainGroup::…) site, not dedup-specific. Fix: mark done only after all registrations succeed, or make individual registrations retryable. Deferred from #5265.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions