-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Drop the top-level vendor/tinycortex submodule in favour of tinymemory's nested copy #6062
Copy link
Copy link
Closed
Labels
infra-ci-releaseCI, release automation, packaging, build containers, and test harnesses.CI, release automation, packaging, build containers, and test harnesses.maintenanceMaintenance work, dependency updates, or cleanup.Maintenance work, dependency updates, or cleanup.priority: highBreaks a specific featureBreaks a specific featurerust-coreCore Rust runtime in src/: CLI, core_server, shared infrastructure.Core Rust runtime in src/: CLI, core_server, shared infrastructure.taskWork item that is not primarily a bug or a feature.Work item that is not primarily a bug or a feature.
Description
Activity
Metadata
Metadata
Assignees
Labels
infra-ci-releaseCI, release automation, packaging, build containers, and test harnesses.CI, release automation, packaging, build containers, and test harnesses.maintenanceMaintenance work, dependency updates, or cleanup.Maintenance work, dependency updates, or cleanup.priority: highBreaks a specific featureBreaks a specific featurerust-coreCore Rust runtime in src/: CLI, core_server, shared infrastructure.Core Rust runtime in src/: CLI, core_server, shared infrastructure.taskWork item that is not primarily a bug or a feature.Work item that is not primarily a bug or a feature.
Summary
Remove the top-level
vendor/tinycortexsubmodule and resolvetinycortex/tinycortex-apithrough the copyvendor/tinymemoryalready vendors (vendor/tinymemory/vendor/tinycortex), so the engine the tests link is by construction the one the prebuilttinymemorymodule was built from.Problem / Context
tinymemory-api(cargo tree -e normal -i tinycortexunder the product feature set prints nothing).tinymemory-core+tinymemory-tinycortexin[dev-dependencies], plus the default-OFFrss-benchbin). Those crates nametinycortex/tinycortex-apiby version requirement;tinycortex-apiis unpublished and crates.io'stinycortexis a stale 0.1.1 — so the root[patch.crates-io]must exist, and its checkout had to be bumped by hand in lockstep withvendor/tinymemory(chore(modules): re-pin tinymemory to v1.15.0 #6049 moved both pointers). A stale top-level pointer silently tests a different engine than the module ships.tinycortex-testsjob runs the engine's own suite on every full Rust CI run (30-minute budget), duplicating tinycortex's own CI;app/src-tauri/Cargo.tomlcarries two patch entries its lock lists as[[patch.unused]]; AGENTS.md's "patches in both manifests" rule describes the pre-Route memory tool and query paths through the module seam so tinymemory-core leaves the build #5560 graph.Scope
In: gitlink +
.gitmodulesremoval; root patch re-point; shell manifest dead patches + lock entries;tinycortex-testsjob inci-lite.yml/test-reusable.yml; AGENTS.md rule; doc comment / architecture doc.Out: removing TinyCortex from the test suite (
[dev-dependencies], ~100 test files, 26 integration targets) — separate project; theLEGACY_MODULE_ID = "tinycortex"config alias; historicaldocs/tinycortex-*.md.Acceptance criteria
vendor/tinycortexgitlink or.gitmodulesentry;git submodule status --recursivelists tinycortex only undervendor/tinymemory/.tinycortex/tinycortex-api→vendor/tinymemory/vendor/tinycortex[/api]; rootCargo.lockunchanged;cargo metadata --lockedpasses for both manifests.cargo tree -e normal --features "$(bash scripts/ci/product-features.sh)" -i tinycortexprints nothing; productcargo checkpasses.cargo check -p openhuman --lib --testspasses;memory::tree_e2e_testsandmemory::sync_pipeline_e2e_testspass.app/src-tauri/Cargo.toml, no[[patch.unused]]for them in its lock; shell all-featurescargo treeshows no engine crates.tinycortex-testsremoved from both workflows with no danglingneeds;PR CI Gatemap updated.[patch]rule states root-manifest-only and why.Related
79131f2)