fix(codeql): break remaining release alert flows - #4556
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 28 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 045d321180
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return ( | ||
| <img | ||
| src={objectUrl ?? EMPTY_IMAGE_SRC} |
There was a problem hiding this comment.
Preserve a renderable fallback for valid attachments
In the Vitest/jsdom environment configured by app/test/vitest.config.ts, URL.createObjectURL is not globally polyfilled, so imageDataUriToObjectUrl() catches that TypeError and this branch renders only the 1x1 spacer for otherwise valid attachmentDataUris. The existing thumbnail coverage in app/src/pages/__tests__/Conversations.attachments.test.tsx still expects user image attachments to render, so the full frontend suite will fail unless the blob URL path is supported in test setup or this component keeps a renderable fallback for validated images.
Useful? React with 👍 / 👎.
Summary
Problem
Conversations.tsxand the mock LLM stream timer inscripts/mock-api/routes/llm.mjs.Solution
Blobobjects, and render generated object URLs instead of assigning the raw data URI to<img src>.setTimeoutonly with those literals.Submission Checklist
Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/codeql-release-alerts-followup045d32118Validation Run
pnpm --dir app exec prettier --write src/pages/Conversations.tsx ../scripts/mock-api/routes/llm.mjsgit diff --check -- app/src/pages/Conversations.tsx scripts/mock-api/routes/llm.mjspnpm --filter openhuman-app format:checkdeferred to GitHub runners per maintainer instruction.pnpm typecheckdeferred to GitHub runners per maintainer instruction.Validation Blocked
command:local CI/test commandserror:maintainer requested tests run on GitHub runners, not locally; local pre-push hook also runs unavailable Rust check path in this checkoutimpact:pushed with--no-verify; PR validation will come from GitHub ActionsBehavior Changes
src; mock stream delays are bounded and rounded.Parity Contract
Duplicate / Superseded PR Handling