fix(build): drop unused std::fs import that fails clippy on main - #5484
Merged
Merged
Conversation
`cargo clippy -- -D warnings` fails on a clean `main`:
error: unused import: `std::fs`
--> src/process_recovery.rs:14:9
The import sits in the macOS `mod imp` block. The `std::fs::` calls
elsewhere in the file are in the Linux block and fully qualified, so
nothing in the macOS block uses it.
It became unused in 1843706 (the CEF -> Wry swap, tinyhumansai#5456), which
removed the macOS reap path that read the filesystem.
The pre-push hook runs `pnpm rust:clippy`, so this currently blocks
every contributor's push regardless of what they changed.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe macOS process-recovery implementation removes an unused ChangesProcess recovery cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12 tasks
senamakel
added a commit
to nocstah/openhuman
that referenced
this pull request
Sep 11, 2026
…-fs\n\nfix(build): drop unused std::fs import that fails clippy on main\n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy -- -D warningsfails on a cleanmain, so the pre-push hook (pnpm rust:clippy) blocks every contributor's push regardless of what they changed.Problem
On
mainatc7e15ba04:The import is inside the
#[cfg(target_os = "macos")] mod impblock atprocess_recovery.rs:11. Thestd::fs::calls further down the file (:484,:498,:537) live in the#[cfg(target_os = "linux")]block at:389and are fully qualified, so nothing in the macOS block ever used it.It became unused in
1843706c3— the CEF → Wry swap in #5456 — which removed the macOS reap path that read the filesystem..husky/pre-pushrunspnpm rust:clippy, and that step has no auto-fix path, so the hook fails for anyone pushing anything until this is removed.Solution
Delete the import.
Submission Checklist
N/A: removing an unused import changes no behaviour and has no failure path to cover.N/A: one deleted line, no changed executable lines.N/A: no feature rows affected.N/A: no feature IDs.N/A: no user-facing surface.Closes #NNN—N/A: no issue filed; found while working #5478.Impact
Build/CI only. No runtime change on any platform — the import was unused in the only configuration that compiled it.
Unblocks the pre-push hook repo-wide.
Related
1843706c3)AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/clippy-unused-fsef9b9b357d1ef17eab347c415dba747caba455dfValidation Run
pnpm --filter openhuman-app format:check—N/A: no frontend files touched.pnpm typecheck—N/A: no TypeScript touched.N/A: no behaviour to test.cargo fmt --manifest-path app/src-tauri/Cargo.toml --all --checkclean.cargo clippy --manifest-path app/src-tauri/Cargo.toml -- -D warnings→ 0 errors (fails with 1 error onupstream/main, verified by clean checkout before and after).Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
grep -n "fs::" app/src-tauri/src/process_recovery.rsshows only fully-qualifiedstd::fs::calls in the Linux block.Duplicate / Superseded PR Handling
Summary by CodeRabbit