fix(deps): repoint vendor/tinyagents to 27a3f39 for gpt-5 max_completion_tokens (release hotfix, #5498) - #5511
Conversation
…ion_tokens release (v0.63.7) pins tinyagents 3e1dbea, whose is_reasoning_model matches only o1/o3/o4, so gpt-5.x chat turns fail with HTTP 400 (unsupported_parameter: 'max_tokens' ... use 'max_completion_tokens'). 27a3f39 - already pinned on main - adds gpt-5 family detection (is_gpt5_family) so the OpenAI request builder emits max_completion_tokens for the gpt-5 family. Advances release's submodule pin to it. Closes tinyhumansai#5498
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — CI Full Gate proves this pin-bump can't ship as an isolated hotfix. Bumping So the 188-commit jump needs its matching openhuman-side changes — which is exactly what a Paths that do work for #5498:
Closing in favor of one of those. |
Summary
release'svendor/tinyagentssubmodule pin3e1dbea→27a3f39(the SHA already pinned onmain), so the shipped build carries the gpt-5 →max_completion_tokensfix.Problem
release(v0.63.7, what production DMGs build from) pins tinyagents3e1dbea, whoseis_reasoning_modelmatches onlyo1/o3/o4. gpt-5.x models rejectmax_tokensand requiremax_completion_tokens, so every chat turn ongpt-5.4-mini/gpt-5.6-lunafails before producing output:mainalready ships the fix (tinyagents27a3f39foldsis_gpt5_familyintois_reasoning_model, routing the cap tomax_completion_tokens; verified — the wire-levelgpt5_sends_max_completion_tokens_not_max_tokenstest and the o-series / classic tests pass,max_tokensis omitted from the body, not sent asnull). It has not reachedrelease.Solution
27a3f39, matchingmain. No openhuman source changes.27a3f39is ~188 tinyagents commits ahead of3e1dbea(the LangChain-parity audit + thesession_store→ top-levelsessionmodule move), andreleasedoes not carry the openhuman-side adaptation that paired with that move onmain(feat(memory): make memory a pluggable subsystem behind a versioned driver contract #5446 —agent/session_dbstill lives in-repo here).release's CI Full Gate builds + tests on all three OSes and is the gate for whether this compiles/works against the olderreleasetree. Draft until that is green.main→release— carries the tinyagents bump and the matching openhuman-side changes together (no divergence). This is the designed path and needs no PR.is_gpt5_familyadded tois_reasoning_model, ~35 lines, no API changes) and pin to that instead. Prepared + verified onYellowSnnowmann/tinyagentsfix/5498-gpt5-max-completion(e742a25); needs a maintainer to land it intinyhumansai/tinyagents(no push access here), after which this PR can repoint to that SHA for a minimal-blast-radius hotfix.Submission Checklist
N/A: submodule-pin change only; the behavioural fix and its tests (routes_max_tokens_to_max_completion_tokens_for_gpt5, wire-levelgpt5_sends_max_completion_tokens_not_max_tokens, o-series, classic) live in tinyagents and pass.N/A: no openhuman source lines changed (one gitlink SHA).N/A: dependency-pin change, no feature rows affected.## Related—N/A: none.N/A: no openhuman release-surface code change; the fix is in the vendored harness.Closes #NNN— see## Related.Impact
gpt-4o/gpt-4-turbokeepmax_tokens).Related
YellowSnnowmann/tinyagentsfix/5498-gpt5-max-completionif a smaller hotfix is preferred.AI Authored PR Metadata (required for Codex/Linear PRs)
N/A— not a Codex/Linear-authored PR.