Skip to content

fix(openhuman-tinyhumans): drop stale peripheral-rpi feature forward - #6356

Merged
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:fix-tinyhumans-peripheral-rpi-feature
Sep 19, 2026
Merged

senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:fix-tinyhumans-peripheral-rpi-feature

Conversation

@senamakel

@senamakel senamakel commented Sep 19, 2026

Copy link
Copy Markdown
Member

Summary

Problem

Root cause, verified directly:

error: failed to select a version for `openhuman-embed`.
    ... required by package `openhuman-tinyhumans v0.63.29 (.../crates/openhuman-tinyhumans)`
package `openhuman-tinyhumans` depends on `openhuman-embed` with feature `peripheral-rpi` but `openhuman-embed` does not have that feature.

Confirmed pre-existing on main at 9084623 (post #6353/#6355 merge), not something newly introduced by this PR.

Solution

  • Drop the one stale line. openhuman-tinyhumans's doc comment states every gate forwards 1:1 to openhuman-embed; this keeps that true.
  • No other reference to peripheral-rpi remains outside vendor/ (checked with a repo-wide grep, excluding vendored benchmark fixtures).

Validation

  • cargo check --manifest-path Cargo.toml — now succeeds (root workspace + openhuman-embed + openhuman-tinyhumans + openhuman-tui).
  • cargo check --manifest-path crates/openhuman-app/Cargo.toml — succeeds, Cargo.lock regenerated.
  • cargo fmt --manifest-path Cargo.toml --all -- --check — clean.
  • node scripts/ci/check-feature-forwarding.mjs — OK, shell forwards exactly the product gate set; every default-ON core gate forwarded.

Submission Checklist

  • Tests added or updated — N/A: Cargo manifest fix, no behavior change; validated by the build succeeding where it previously failed.
  • Diff coverage — N/A: no app/src or new Rust logic.
  • Coverage matrix updated — N/A.
  • All affected feature IDs listed under ## Related — N/A.
  • No new external network dependencies introduced.
  • Manual smoke checklist updated — N/A.
  • Linked issue closed — N/A: no issue, direct fix for main breakage.
  • pnpm --filter openhuman-app format:check — N/A, no app/ TS changes.
  • pnpm typecheck — N/A, no TypeScript changes.
  • Focused tests: cargo check --manifest-path Cargo.toml, cargo check --manifest-path crates/openhuman-app/Cargo.toml, cargo fmt --all -- --check, node scripts/ci/check-feature-forwarding.mjs.
  • Rust fmt/check: done, see above.
  • Tauri fmt/check: cargo check --manifest-path crates/openhuman-app/Cargo.toml above.

Related

Summary by CodeRabbit

  • Changes
    • Removed the peripheral-rpi feature option from the TinyHumans package.

senamakel and others added 2 commits September 19, 2026 20:24
Update the `tinyrand` crate dependency from version 0.5.0 to 0.6.0 in the `openhuman-tinyhumans` package to stay current with the latest upstream release.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
…ncies

The Cargo.lock file is updated to reflect the renaming of the `openhuman-session` crate to `openhuman-tinyhumans` and the addition of the new `openhuman-embed` crate as a dependency.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel requested a review from a team September 19, 2026 17:30
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a1b19aab-9f1d-4602-a385-12d958c1a165

📥 Commits

Reviewing files that changed from the base of the PR and between 9084623 and c601a46.

⛔ Files ignored due to path filters (1)
  • crates/openhuman-app/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/openhuman-tinyhumans/Cargo.toml
💤 Files with no reviewable changes (1)
  • crates/openhuman-tinyhumans/Cargo.toml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PR removes the peripheral-rpi feature from crates/openhuman-tinyhumans/Cargo.toml. Other feature declarations remain unchanged.

Changes

Feature declaration cleanup

Layer / File(s) Summary
Remove Raspberry Pi feature forwarding
crates/openhuman-tinyhumans/Cargo.toml
Removes the peripheral-rpi feature that forwarded to openhuman-embed/peripheral-rpi.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: al629176

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the stale peripheral-rpi feature forwarding entry from openhuman-tinyhumans.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit checks the feature line
The Raspberry Pi flag leaves the sign
The other entries stay
Neat and unchanged today
Cargo hops along just fine

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit 3669eac into tinyhumansai:main Sep 19, 2026
16 of 24 checks passed
@tinysweeper

tinysweeper Bot commented Sep 19, 2026

Copy link
Copy Markdown

Tiny Sweeper review

This pull request removes a stale feature forward 'peripheral-rpi' from the Cargo.toml of the openhuman-tinyhumans crate.

State: Ready for maintainer review
Priority: none
Reviewed head: c601a46c1994
Updated: 1789841369 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

Removed the 'peripheral-rpi' feature forward from Cargo.toml.

Features

  • Removed — peripheral-rpi feature forward: The 'peripheral-rpi' feature forward is no longer exposed by the crate; this cleans up a stale or unused feature. (crates/openhuman-tinyhumans/Cargo.toml)

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors, deepseek-v4-flash
  • Spend: $0.000067
  • Tokens: 1151 input · 1237 output · 0 cached · 62 embedding
Head State Pass summary
c601a46c1994 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1789841369)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0001 · 1,151 in / 1,237 out · 0 cached (0%) · 62 embedded · ladder/vectors, deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant