Conversation
Update the `tinyrand` crate dependency from version 0.5.0 to 0.6.0 in the `openhuman-tinyhumans` package to stay current with the latest upstream release. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
…ncies The Cargo.lock file is updated to reflect the renaming of the `openhuman-session` crate to `openhuman-tinyhumans` and the addition of the new `openhuman-embed` crate as a dependency. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR removes the ChangesFeature declaration cleanup
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the feature line Comment |
Tiny Sweeper reviewThis pull request removes a stale feature forward 'peripheral-rpi' from the Cargo.toml of the openhuman-tinyhumans crate. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedRemoved the 'peripheral-rpi' feature forward from Cargo.toml. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Summary
maincurrently fails to compile:openhuman-tinyhumans(added by refactor(tinyhumans): merge openhuman-session into openhuman-tinyhumans; hosts install the transport (P2) #6354, tinyhumans-layer-p2) still forwards aperipheral-rpi = ["openhuman-embed/peripheral-rpi"]feature that chore(scripts): add tinyanalyzer-driven dependency audit across core and vendor submodules #6353/chore(deps): drop unused dependencies and stale pins found by the dependency audit #6355 (dependency-audit clean-up) removed fromopenhuman-embedshortly after, because the clean-up branch wasn't rebased onto refactor(tinyhumans): merge openhuman-session into openhuman-tinyhumans; hosts install the transport (P2) #6354 before landing.cargo check --manifest-path Cargo.tomlon currentmain(9084623) fails withopenhuman-embeddoes not have that feature.crates/openhuman-tinyhumans/Cargo.toml, matching the removal already done incrates/openhuman-embed/Cargo.tomlby chore(deps): drop unused dependencies and stale pins found by the dependency audit #6355.crates/openhuman-app/Cargo.lock(its own lockfile, excluded from the root workspace) for the updated feature/dependency set.Problem
Root cause, verified directly:
Confirmed pre-existing on
mainat 9084623 (post #6353/#6355 merge), not something newly introduced by this PR.Solution
openhuman-tinyhumans's doc comment states every gate forwards 1:1 toopenhuman-embed; this keeps that true.peripheral-rpiremains outsidevendor/(checked with a repo-wide grep, excluding vendored benchmark fixtures).Validation
cargo check --manifest-path Cargo.toml— now succeeds (root workspace + openhuman-embed + openhuman-tinyhumans + openhuman-tui).cargo check --manifest-path crates/openhuman-app/Cargo.toml— succeeds,Cargo.lockregenerated.cargo fmt --manifest-path Cargo.toml --all -- --check— clean.node scripts/ci/check-feature-forwarding.mjs— OK, shell forwards exactly the product gate set; every default-ON core gate forwarded.Submission Checklist
app/srcor new Rust logic.## Related— N/A.pnpm --filter openhuman-app format:check— N/A, noapp/TS changes.pnpm typecheck— N/A, no TypeScript changes.cargo check --manifest-path Cargo.toml,cargo check --manifest-path crates/openhuman-app/Cargo.toml,cargo fmt --all -- --check,node scripts/ci/check-feature-forwarding.mjs.cargo check --manifest-path crates/openhuman-app/Cargo.tomlabove.Related
Summary by CodeRabbit
peripheral-rpifeature option from the TinyHumans package.