fix(openhuman-tinyhumans): drop forward of the removed peripheral-rpi feature - #6359
Conversation
…add openhuman-embed The openhuman-session dependency has been replaced with openhuman-tinyhumans in the app's lockfile, and a new openhuman-embed crate has been added as a dependency. The peripheral-rpi feature flag has been removed from the tinyhumans crate's Cargo.toml as part of this restructuring. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
Tiny Sweeper reviewRemoves the forwarding of the `peripheral-rpi` feature from the `openhuman-tinyhumans` crate because the underlying feature was already removed from the `openhuman-embed` dependency, preventing a Cargo feature error and cleaning up dead configuration. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedRemoved the `peripheral-rpi` feature line from `crates/openhuman-tinyhumans/Cargo.toml`. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Summary
maindoes not resolve since chore(deps): drop unused dependencies and stale pins found by the dependency audit #6355 merged: refactor(tinyhumans): merge openhuman-session into openhuman-tinyhumans; hosts install the transport (P2) #6354 (landed in between) addedcrates/openhuman-tinyhumans, which forwardsperipheral-rpitoopenhuman-embed, and chore(deps): drop unused dependencies and stale pins found by the dependency audit #6355 removed that feature from embed/core (it gatedrppal, which nothing used). Everycargoinvocation onmainfails withpackage openhuman-tinyhumans depends on openhuman-embed with feature peripheral-rpi but openhuman-embed does not have that feature.crates/openhuman-app/Cargo.lock, which was stale against refactor(tinyhumans): merge openhuman-session into openhuman-tinyhumans; hosts install the transport (P2) #6354'sopenhuman-session→openhuman-tinyhumansrename (the app crate cannot build--lockedwithout it).Problem
Two PRs each valid against the
mainthey were opened on removed and added the same feature name; CI Lite'sRust QualityandRust Feature-Gate Smokejobs onmainfail at dependency resolution.Solution
Delete the forward; there is no crate behind the feature any more. Verified:
cargo check -p openhuman --no-default-features,cargo check --workspace --lib --bins,cargo check --manifest-path crates/openhuman-app/Cargo.toml, andnode scripts/ci/check-feature-forwarding.mjsall pass.Submission Checklist
## Related— N/A.Impact
main.openhuman-tinyhumansloses a feature name that enabled nothing.Related
main(Frontend ChecksTS6133 inapp/src/**/Conversations*.test.tsx, Rust test-target drift againsttinytools/tinyinference) predate chore(scripts): add tinyanalyzer-driven dependency audit across core and vendor submodules #6353/chore(deps): drop unused dependencies and stale pins found by the dependency audit #6355 — red since Migrate agent runtime to TinyAgents hosted harness #6348 — and are not addressed here.AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix-peripheral-rpi-forwardValidation Run
pnpm --filter openhuman-app format:check— N/Apnpm typecheck— N/Acargo check --manifest-path crates/openhuman-app/Cargo.tomlclean.Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Summary by CodeRabbit
peripheral-rpibuild feature from the TinyHumans package.