Skip to content

test: cover hosted voice transcription transport - #26

Merged
senamakel merged 1 commit into
mainfrom
coverage-90
Sep 20, 2026
Merged

senamakel merged 1 commit into
mainfrom
coverage-90

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

  • add deterministic local HTTP tests for hosted transcription validation, multipart success, authorization, and safe failure redaction
  • add Axum as a voice crate test dependency
  • raise hosted transcription transport coverage to 90.40%

Verification

  • cargo fmt --all -- --check
  • cargo clippy -p tinyinference-voice --all-targets --all-features -- -D warnings
  • cargo test -p tinyinference-voice --all-features
  • cargo test --workspace --all-features --quiet
  • cargo test -p tinyinference-llm --test tool_validation --quiet
  • cargo llvm-cov -p tinyinference-voice --all-features --summary-only

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

Or wait 18 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f55fddc7-d732-40db-be8b-e2b1642414ff

📥 Commits

Reviewing files that changed from the base of the PR and between baf39b6 and 56608b7.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/tinyinference-voice/Cargo.toml
  • crates/tinyinference-voice/src/cloud.rs

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T07:59:17.655236Z 56608b7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56608b7568

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

let captured = Arc::clone(&authorization);
let app = Router::new().route(
"/v1/audio/transcriptions",
post(move |headers: HeaderMap| {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Assert the multipart body in the upload test

The handler extracts only the authorization header and never reads or validates the request body. If transcribe regresses to sending an empty body, JSON, incorrect audio bytes, or omits the default model, filename, or MIME type, this test will still return 200 and pass despite its stated multipart/defaults coverage. Capture the content type and multipart body and assert the expected fields and decoded bytes.

Useful? React with 👍 / 👎.

@senamakel
senamakel merged commit aeaecda into main Sep 20, 2026
7 checks passed
@tinysweeper

tinysweeper Bot commented Sep 20, 2026

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 56608b7568fa
Updated: 1789891637 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["nonempty<br/>changed"]:::changed
  n1["transcribe"]:::impacted
  n2["sanitize_response_detail"]:::impacted
  n3["len"]:::impacted
  n4["bounded_response_body"]:::impacted
  n5["...zation_removes_exact_and_prefixed_secrets"]:::impacted
  n6["sanitize_api_error"]:::impacted
  n1 -->|calls| n0
  n1 -->|calls| n2
  n1 -->|calls| n3
  n1 -->|calls| n4
  n2 -->|calls| n6
  n4 -->|calls| n3
  n5 -->|calls| n2
  n5 -->|tests| n2
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 2 files; 0 findings. _The code index is behind this pull request (indexed at `55875a6fd65f`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 2 files; 0 findings. _The code index is behind this pull request (indexed at `55875a6fd65f`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Adds deterministic local HTTP tests for hosted voice transcription validation, multipart success, authorization, and safe failure redaction, raising transport coverage to ~90%. The tests use a synthetic Axum server and do not depend on external network or credentials. No rule violations found. _The code index is behind this pull request (indexed at `55875a6fd65f`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash
  • Spend: $0.008424
  • Tokens: 113954 input · 6714 output · 5095 cached · 340 embedding
Head State Pass summary
56608b7568fa ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1789891637)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0084 · 113,954 in / 6,714 out · 5,095 cached (4%)  · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 340 embedded
critique:    $0.0033 · 47,983 in  / 1,575 out · 2,029 cached (4%)  · gpt-5.6-luna
security:    $0.0038 · 58,744 in  / 976 out   · 1,786 cached (3%)  · gpt-5.6-luna
description: $0.0006 · 4,346 in   / 1,789 out · 1,280 cached (29%) · deepseek/deepseek-v4-flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant