test: cover hosted voice transcription transport - #26
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50. Or wait 18 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56608b7568
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let captured = Arc::clone(&authorization); | ||
| let app = Router::new().route( | ||
| "/v1/audio/transcriptions", | ||
| post(move |headers: HeaderMap| { |
There was a problem hiding this comment.
Assert the multipart body in the upload test
The handler extracts only the authorization header and never reads or validates the request body. If transcribe regresses to sending an empty body, JSON, incorrect audio bytes, or omits the default model, filename, or MIME type, this test will still return 200 and pass despite its stated multipart/defaults coverage. Capture the content type and multipart body and assert the expected fields and decoded bytes.
Useful? React with 👍 / 👎.
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["nonempty<br/>changed"]:::changed
n1["transcribe"]:::impacted
n2["sanitize_response_detail"]:::impacted
n3["len"]:::impacted
n4["bounded_response_body"]:::impacted
n5["...zation_removes_exact_and_prefixed_secrets"]:::impacted
n6["sanitize_api_error"]:::impacted
n1 -->|calls| n0
n1 -->|calls| n2
n1 -->|calls| n3
n1 -->|calls| n4
n2 -->|calls| n6
n4 -->|calls| n3
n5 -->|calls| n2
n5 -->|tests| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0084 · 113,954 in / 6,714 out · 5,095 cached (4%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 340 embedded
critique: $0.0033 · 47,983 in / 1,575 out · 2,029 cached (4%) · gpt-5.6-luna
security: $0.0038 · 58,744 in / 976 out · 1,786 cached (3%) · gpt-5.6-luna
description: $0.0006 · 4,346 in / 1,789 out · 1,280 cached (29%) · deepseek/deepseek-v4-flash
Summary
Verification