Test relative workspace containment

[senamakel]

Summary

Adds a regression test confirming that workspace descriptors anchor relative roots and candidate paths to the process current directory.

Related issue

None.

API or behavior changes

None.

Validation

• cargo fmt --all -- --check
• cargo clippy --all-targets --all-features -- -D warnings
• cargo build --all-targets --all-features
• cargo test --all-features
• .github/scripts/check-file-coverage.sh 90 coverage.json (97.63% total; every source file meets the 90% requirement)

Tests

Added relative_roots_and_candidates_are_anchored_to_the_current_directory.

Documentation

No documentation change: this is coverage for documented existing behavior.

Checklist

• The change is focused on one logical change
• No new #[allow(...)], #[ignore], or relaxed lints
• No secrets, tokens, or .env contents in the diff or the description

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 1 billable file and costs up to $0.25.}

Or wait 23 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 96649be8-43b3-422a-9b75-5cc879f4547c

📥 Commits

Reviewing files that changed from the base of the PR and between d11d409 and d33da6d.

📒 Files selected for processing (1)

• crates/tinytools/src/workspace/test.rs

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-20T07:54:13.826850Z	d33da6d	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[tinysweeper]

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: d33da6d6e25c
Updated: 1789891224 (Unix time)

Review snapshot

Change surface	Files	Review signal	Count
Production	0	Active findings	0
Tests	1	Noted findings	0
Documentation	0	Resolved findings	0
Configuration	0	Pending checks/questions	0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["with_trusted_root"]:::impacted
  n1["...iptor_is_pinned_to_its_literal_wire_shape"]:::impacted
  n2["the_descriptor_round_trips_through_json"]:::impacted
  n3["the_builders_set_each_field"]:::impacted
  n4["with_policy_id"]:::impacted
  n5["with_sandbox"]:::impacted
  n1 -->|calls| n0
  n1 -->|tests| n0
  n1 -->|calls| n4
  n1 -->|tests| n4
  n1 -->|calls| n5
  n1 -->|tests| n5
  n2 -->|calls| n0
  n2 -->|tests| n0
  n2 -->|calls| n4
  n2 -->|tests| n4
  n2 -->|calls| n5
  n2 -->|tests| n5
  n3 -->|calls| n0
  n3 -->|tests| n0
  n3 -->|calls| n4
  n3 -->|tests| n4
  n3 -->|calls| n5
  n3 -->|tests| n5
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff

Loading

Agent review details

critique

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Lane summary: The added test correctly verifies that relative workspace roots and candidates are anchored to the current directory. The change is safe to merge. _The code index is behind this pull request (indexed at `77df07f399d7`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

security

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Lane summary: The change adds deterministic coverage for anchoring relative workspace roots and candidates to the current directory. It introduces no security or authorization issues and looks safe to merge. _The code index is behind this pull request (indexed at `77df07f399d7`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

tests

• Conclusion: Neutral
• Scope reviewed: all assigned evidence
• Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

• Conclusion: Neutral
• Scope reviewed: all assigned evidence
• Lane summary: Nothing sensitive found in what this pull request commits.

description

• Conclusion: Success
• Scope reviewed: all assigned evidence
• Lane summary: Adds a regression test verifying that WorkspaceDescriptor anchors relative roots and candidate paths to the current directory. The test is deterministic, follows project conventions, and introduces no problems. _The code index is behind this pull request (indexed at `77df07f399d7`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

• Conclusion: Neutral
• Scope reviewed: all assigned evidence
• Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

Evidence and run details

• Models: ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash
• Spend: $0.002701
• Tokens: 29219 input · 3679 output · 0 cached · 98 embedding

Head	State	Pass summary
d33da6d6e25c	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 1789891224)

[tinysweeper]

tinysweeper found nothing blocking. Approving.

             $0.0027 · 29,219 in / 3,679 out · 0 cached (0%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 98 embedded
critique:    $0.0009 · 12,272 in / 473 out   · 0 cached (0%) · gpt-5.6-luna
security:    $0.0009 · 12,028 in / 425 out   · 0 cached (0%) · gpt-5.6-luna
description: $0.0006 · 3,424 in  / 1,765 out · 0 cached (0%) · deepseek/deepseek-v4-flash