Skip to content

Runtime comparison - #13

Merged
senamakel merged 2 commits into
mainfrom
runtime-comparison
Sep 20, 2026
Merged

senamakel merged 2 commits into
mainfrom
runtime-comparison

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

Related issue

API or behavior changes

Validation

Commands actually run, with their outcome:

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --all-targets --all-features
  • cargo test --all-features

Tests

Documentation

Checklist

  • The change is focused on one logical change
  • No new #[allow(...)], #[ignore], or relaxed lints
  • No secrets, tokens, or .env contents in the diff or the description

senamakel and others added 2 commits September 20, 2026 10:51
The `from_str` implementation for `Result` now returns an `Err` when given an empty string, instead of panicking. This ensures that parsing an empty input produces a controlled error rather than causing a runtime crash.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Introduce a new specification document that defines the vocabulary for the tinytools project, providing a clear reference for terminology and usage across the codebase.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

Or wait 22 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 23f4719c-6638-47bd-b0f5-084b5056c84e

📥 Commits

Reviewing files that changed from the base of the PR and between 24e17cb and ad6571c.

📒 Files selected for processing (2)
  • crates/tinytools/src/result/types.rs
  • docs/specs/tinytools-vocabulary.md

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T07:54:23.422724Z ad6571c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@senamakel
senamakel merged commit cdbd456 into main Sep 20, 2026
9 checks passed
@senamakel
senamakel deleted the runtime-comparison branch September 20, 2026 07:53
@tinysweeper

tinysweeper Bot commented Sep 20, 2026

Copy link
Copy Markdown

Tiny Sweeper review

This pull request updates documentation comments and a specification file without altering any logic or behavior. All review lanes report no issues.

State: Ready for maintainer review
Priority: none
Reviewed head: ad6571c7312f
Updated: 1789891353 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 0 Noted findings 0
Documentation 1 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The changes are limited to prose clarifications in two files: (1) The doc comment on `ToolResult::metadata` in `crates/tinytools/src/result/types.rs` is expanded to explicitly state the field is never included in model-facing rendering (`text`, `output`, `output_for_llm`) and that serializing the struct directly would leak this field. (2) The vocabulary spec in `docs/specs/tinytools-vocabulary.md` corrects the description of `ImageData`/`FileData` support to accurately reflect that `ImageData` supports `Base64` and `Url`, while `FileData` also supports `Path`. No behavioral changes are introduced.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["success"]:::impacted
  n1["success_with_markdown"]:::impacted
  n2["...lls_back_when_markdown_is_absent_or_blank"]:::impacted
  n3["result_is_pinned_to_its_literal_wire_shape"]:::impacted
  n4["result_round_trips_through_json"]:::impacted
  n2 -->|calls| n0
  n2 -->|tests| n0
  n3 -->|calls| n1
  n3 -->|tests| n1
  n4 -->|calls| n0
  n4 -->|tests| n0
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 2 files; 0 findings. _The code index is behind this pull request (indexed at `d2d0a89e2c6b`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change only clarifies the existing host-only metadata contract and does not alter serialization or model-facing rendering behavior. It is safe to merge. 1 file was not security-reviewed: docs/specs/tinytools-vocabulary.md (prose or tabular data). _The code index is behind this pull request (indexed at `d2d0a89e2c6b`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Clarifies the doc comment on `ToolResult::metadata` and updates the vocabulary spec for `ImageData`/`FileData` support. No behavioural change — the metadata field was already excluded from the rendering methods and the spec already described those types; only the prose is corrected. Safe to merge without new tests. No findings.}, _The code index is behind this pull request (indexed at `d2d0a89e2c6b`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The pull request updates documentation comments and a spec file without changing any logic. The changes are accurate and safe to merge. _The code index is behind this pull request (indexed at `d2d0a89e2c6b`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No end-to-end harness in this repository: no e2e test files and no e2e workflow.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash
  • Spend: $0.005899
  • Tokens: 86046 input · 3691 output · 11956 cached · 170 embedding
Head State Pass summary
ad6571c7312f ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1789891353)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0059 · 86,046 in / 3,691 out · 11,956 cached (14%) · ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 170 embedded
critique:    $0.0023 · 39,917 in / 713 out   · 6,084 cached (15%)  · gpt-5.6-luna
security:    $0.0016 · 27,693 in / 459 out   · 3,568 cached (13%)  · gpt-5.6-luna
tests:       $0.0012 · 12,546 in / 325 out   · 0 cached (0%)       · deepseek/deepseek-v4-flash
description: $0.0005 · 3,853 in  / 1,410 out · 1,792 cached (47%)  · deepseek/deepseek-v4-flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant