Skip to content

chore(deps): drop unused ripemd and serde dependencies - #33

Merged
senamakel merged 1 commit into
mainfrom
dep-audit
Sep 19, 2026
Merged

senamakel merged 1 commit into
mainfrom
dep-audit

Conversation

@senamakel

@senamakel senamakel commented Sep 19, 2026

Copy link
Copy Markdown
Member

Summary

Found by the cross-repo dependency audit in tinyhumansai/openhuman#6353 (pnpm dep:audit, tinyanalyzer-driven) and verified by grep against this tree at main. Manifest and lockfile only; no source changes.

  • tinywallet-bus: drop the optional ripemd and its dep:ripemd entry in the btc feature — nothing under crates/tinywallet-bus/src references it; the only RIPEMD-160 use in the repo is src/key/btc.rs in the root tinywallet crate, which keeps its own ripemd.
  • tinywallet-module: drop serde — no derive or path use in the crate.

Related issue

None.

API or behavior changes

None.

Validation

Commands actually run, with their outcome:

  • cargo fmt --all -- --check — clean
  • cargo clippy --workspace --all-targets --all-features -- -D warnings — clean (on stable 1.98; the repo's #[allow(clippy::unused_async_trait_impl)] is unknown to 1.96 and earlier)
  • cargo check --workspace --all-targets --all-features — clean
  • cargo test --workspace --all-features — 351 passed, 0 failed

Tests

None added: dependency removal is verified by the build, not by a test.

Documentation

Not needed; no public surface changed.

Checklist

  • The change is focused on one logical change
  • No new #[allow(...)], #[ignore], or relaxed lints
  • No secrets, tokens, or .env contents in the diff or the description

Summary by CodeRabbit

  • Chores
    • Streamlined Bitcoin feature dependencies by removing an unused hashing dependency.
    • Reduced module dependency configuration by removing an unnecessary serialization dependency.
    • No user-facing functionality or behavior changes are included in this update.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-19T16:31:04.957541Z d13a5b3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bcb0bc6e-4748-4724-992a-746fb30cd9f2

📥 Commits

Reviewing files that changed from the base of the PR and between c7477ec and d13a5b3.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/tinywallet-bus/Cargo.toml
  • crates/tinywallet-module/Cargo.toml
💤 Files with no reviewable changes (1)
  • crates/tinywallet-module/Cargo.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request removes the optional ripemd dependency from the bus crate and removes serde from the module crate. The btc feature no longer enables ripemd.

Changes

Dependency Cleanup

Layer / File(s) Summary
Remove unused manifest dependencies
crates/tinywallet-bus/Cargo.toml, crates/tinywallet-module/Cargo.toml
The bus crate removes optional ripemd support and its btc feature entry. The module crate removes its direct serde dependency.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the unused ripemd and serde dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit checks the manifest with care
RIPEMD hops out of the Bitcoin pair
Serde leaves the module nest
Leaner crates can take a rest
Clean features now grow light as air

Comment @coderabbitai help to get the list of available commands.

@tinysweeper

tinysweeper Bot commented Sep 19, 2026

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: d13a5b33645a
Updated: 1789835620 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 2 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change removes the unused `ripemd` dependency from `tinywallet-bus` and stops enabling it through the `btc` feature. The manifest remains consistent with the crate contents and is safe to merge. _The code index for this repository is cold, so this review saw the diff alone._ _1 memory call(s) failed (model: cortex: v1/answer answered 502 Bad Gateway), so this review saw part of what the engine holds._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change removes an unused optional `ripemd` dependency from the Bitcoin feature without affecting the crate's code paths. The change looks safe to merge. _The code index for this repository is cold, so this review saw the diff alone._ _1 memory call(s) failed (model: cortex: v1/answer answered 502 Bad Gateway), so this review saw part of what the engine holds._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: This pull request removes two unused dependencies (`ripemd` from `tinywallet-bus` and `serde` from `tinywallet-module`), confirmed by grep and passing build. No API or behavior changes; safe to merge. _The code index for this repository is cold, so this review saw the diff alone._ _1 memory call(s) failed (model: cortex: v1/answer answered 502 Bad Gateway), so this review saw part of what the engine holds._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: flash, gpt-5.6-luna, deepseek-v4-flash
  • Spend: $0.002380
  • Tokens: 45185 input · 5000 output · 4840 cached · 0 embedding
Head State Pass summary
d13a5b33645a ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1789835620)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0024 · 45,185 in / 5,000 out · 4,840 cached (11%) · flash, gpt-5.6-luna, deepseek-v4-flash
critique:    $0.0010 · 17,127 in / 412 out   · 2,030 cached (12%) · gpt-5.6-luna
security:    $0.0009 · 14,946 in / 421 out   · 1,786 cached (12%) · gpt-5.6-luna
description: $0.0001 · 7,609 in  / 615 out   · 1,024 cached (13%) · deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 19, 2026
@senamakel
senamakel merged commit 0398716 into main Sep 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant