Skip to content

[codex] adopt shared Bazel package workflow#11

Merged
Jesssullivan merged 1 commit intomainfrom
jess/tin-103-disable-org-fork-publish-and-align-metadata
Apr 17, 2026
Merged

[codex] adopt shared Bazel package workflow#11
Jesssullivan merged 1 commit intomainfrom
jess/tin-103-disable-org-fork-publish-and-align-metadata

Conversation

@Jesssullivan
Copy link
Copy Markdown

Summary

  • migrate the downstream fork to the shared Bazel JS package workflow
  • keep publish rehearsal non-authoritative with dry_run: true
  • preserve advisory lint and typecheck lanes so existing fork debt stays visible without blocking the rehearsal lane
  • pin the reusable workflow reference to the reviewed ci-templates commit

Why

The downstream fork should share the same rehearsal contract as the authoritative repos without pretending it is clean or publish-authoritative. This keeps the fork aligned while still reflecting its real state.

Validation

  • parsed .github/workflows/ci.yml
  • parsed .github/workflows/publish.yml
  • confirmed the fork still has real advisory lint and check debt

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 16, 2026

Greptile Summary

This PR replaces the fork's bespoke CI/CD config with the shared js-bazel-package.yml reusable workflow (pinned to a specific ci-templates commit), splitting responsibilities across a push/PR-triggered CI lane and a manual-only publish rehearsal lane. Both workflows keep dry_run: true so the fork can never accidentally become publish-authoritative, while advisory continue_on_error flags on lint and typecheck keep existing fork debt visible without blocking the pipeline.

Confidence Score: 5/5

Safe to merge — both workflows correctly enforce dry_run and no logic issues were found.

Changes are limited to two GitHub Actions workflow files. The security-sensitive properties (commit-pinned reusable workflow reference, dry_run: true in both files, advisory-only lint/typecheck) are all correctly configured. No P0 or P1 findings were identified.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Migrates CI to the shared reusable js-bazel-package.yml workflow pinned at a reviewed commit SHA; correctly enforces dry_run: true and advisory continue_on_error lanes for lint/typecheck.
.github/workflows/publish.yml Introduces a manual-only publish rehearsal workflow using the same pinned reusable workflow; adds github_package_name for the personal-scoped GitHub Packages mirror and keeps dry_run: true throughout.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([push or pull_request to main]) --> CI
    B([workflow_dispatch]) --> CI
    B --> PUB

    subgraph CI [ci.yml - CI]
        CI1[js-bazel-package.yml at dde8c378]
    end

    subgraph PUB [publish.yml - Downstream Publish Rehearsal]
        PUB1[js-bazel-package.yml at dde8c378 with github_package_name jesssullivan]
    end

    CI1 --> P1
    PUB1 --> P1

    P1[prepare: pnpm exec svelte-kit sync] --> P2
    P2[advisory lint - continue_on_error true] --> P3
    P3[advisory typecheck - continue_on_error true] --> P4
    P4[unit tests and integration tests] --> P5
    P5[build and package check] --> P6
    P6[Bazel target pkg] --> P7
    P7[dry_run true - publish rehearsal only]
Loading

Reviews (7): Last reviewed commit: "chore: adopt shared bazel package workfl..." | Re-trigger Greptile

Comment thread scripts/check-release-metadata.mjs
@Jesssullivan Jesssullivan force-pushed the jess/tin-103-disable-org-fork-publish-and-align-metadata branch from c2d688a to 663b931 Compare April 17, 2026 02:29
@Jesssullivan Jesssullivan marked this pull request as ready for review April 17, 2026 02:36
@Jesssullivan Jesssullivan merged commit b4661a5 into main Apr 17, 2026
1 check passed
@Jesssullivan Jesssullivan deleted the jess/tin-103-disable-org-fork-publish-and-align-metadata branch April 17, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant