Conversation
Greptile SummaryThis PR updates the broken SHA pin for the shared Confidence Score: 5/5Safe to merge — the SHA pin fix is the primary goal and the command change is a P2 clarification question, not a blocker. All findings are P2: the No files require special attention beyond the clarification on Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant CI as ci.yml / publish.yml
participant TPL as tinyland-inc/ci-templates js-bazel-package.yml@f2e12c1
GH->>CI: trigger (push / PR / workflow_dispatch)
CI->>TPL: uses reusable workflow (new SHA pin)
TPL->>TPL: prepare (pnpm exec svelte-kit sync)
TPL->>TPL: lint & typecheck
TPL->>TPL: unit + integration tests
TPL->>TPL: build (pnpm build)
TPL->>TPL: package_check (pnpm exec publint)
TPL->>TPL: bazel build //:pkg
TPL-->>CI: workflow result
CI-->>GH: pass / fail
Reviews (1): Last reviewed commit: "align mirror package validation" | Re-trigger Greptile |
| integration_test_command: pnpm test:integration | ||
| build_command: pnpm build | ||
| package_check_command: pnpm check:package | ||
| package_check_command: pnpm exec publint |
There was a problem hiding this comment.
The PR description only mentions updating the workflow SHA pin, but both files also change package_check_command from pnpm check:package to pnpm exec publint. pnpm check:package is a package.json script that could wrap publint with additional flags or run extra checks; pnpm exec publint runs the binary directly with no arguments. If check:package included extra options (e.g., --strict, a specific entrypoint, or additional validations), those would be silently dropped. Is this intentional, and is check:package now gone from package.json?
| integration_test_command: pnpm test:integration | ||
| build_command: pnpm build | ||
| package_check_command: pnpm check:package | ||
| package_check_command: pnpm exec publint |
There was a problem hiding this comment.
Undocumented command change (same as ci.yml)
Same undocumented package_check_command change from pnpm check:package to pnpm exec publint appears here as well. If the intent is to drop the custom script in favour of running publint directly, that should be noted in the PR description, and the check:package script should be removed from package.json to avoid confusion.
Summary
Why
tinyland-inc/scheduling-kitmainis currently red because it still points attinyland-inc/ci-templates/.github/workflows/js-bazel-package.yml@dde8c378815e47aa027c163278430c0d98ae007b, which is no longer resolvable. The canonicalJesssullivan/scheduling-kitrepo is already green onmain; this PR is only to stop the downstream mirror from lying about package-lane health.Validation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml"); YAML.load_file(".github/workflows/publish.yml")'git diff --check