Add color bar (live updated) for 2D scans#106
Open
FlorenceBerterottiere wants to merge 2 commits into
Open
Conversation
antti-ethz
previously approved these changes
May 27, 2026
Collaborator
antti-ethz
left a comment
antti-ethz
left a comment
There was a problem hiding this comment.
Well done replacing updateVisualMap() with a declarative approach, it's better now.
One heads-up for merging into main: there's a real conflict in ResultChannelPlot.tsx in the effects block - main still has the old updateVisualMap effect and a new onChartClick effect.
added 2 commits
June 1, 2026 16:38
…e so as to have always the max contrast for 2D scans
FlorenceBerterottiere
force-pushed
the
fix/2d_scan_color_scale
branch
from
52807e4 to
5a14ec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #92
Now the color scale for 2D plots is properly displayed, and is updated live such as to have always the most contrast of our incoming data.
Example as the data comes in first:
then the color bar is updated as more data comes in
