Fix scripting client parameter identifier#111
Open
FlorenceBerterottiere wants to merge 3 commits into
Open
Conversation
added 2 commits
May 27, 2026 13:36
…ong name, and raise an exception if long name is not unique
aferk
changed the title
aferk
added
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the comments of a PR #94 , @aferk has suggested that the display group identifier names could potentially collide, with 3 potential fixes
" Recursively prepend identifiers until the name is unique
Check if the short name is unique and if not, use the original name
Check if the short name is unique and if not use the long one. If the long one is not unique raise an exception."
Implemented suggestion 3).
Sorry for the mess as I saw this comments after merging PR #94 !
Thanks :)