Replace bare exception fallbacks with specific logging#216
Merged
tirth8205 merged 1 commit intotirth8205:mainfrom Apr 11, 2026
Merged
Conversation
35b9d3e to
0bca4f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194.
Summary
This PR replaces bare
except Exceptionfallbacks in optional-path code with narrower exception handling and debug logging, while preserving the existing graceful fallback behavior.What Changed
code_review_graph/graph.pycode_review_graph/wiki.pycode_review_graph/visualization.pycode_review_graph/migrations.pycode_review_graph/tools/context.pycode_review_graph/parser.pycode_review_graph/tsconfig_resolver.pycode_review_graph/registry.pycode_review_graph/cli.pycode_review_graph/eval/benchmarks/search_quality.py{},[],None, and"dev"Tests
tests/test_cli.pyfor_get_version()fallback loggingtests/test_graph.pyVerification
./.venv/bin/python -m pytest tests --tb=short -q618 passed, 5 skipped, 2 xpassedNotes
This change is intentionally scoped to the issue-reported bare fallback handlers and does not alter existing
except Exception as epaths that already log or return structured errors.