perf: eliminate N+1 SQL queries in _compute_summaries#244
Open
ankitwasankar wants to merge 1 commit intotirth8205:mainfrom
Open
perf: eliminate N+1 SQL queries in _compute_summaries#244ankitwasankar wants to merge 1 commit intotirth8205:mainfrom
ankitwasankar wants to merge 1 commit intotirth8205:mainfrom
Conversation
Replace per-community and per-node query loops with precomputed aggregate queries + executemany batch inserts. community_summaries: 2 queries per community -> 3 total - single GROUP BY query for top symbols across all communities - single flat SELECT for all file paths across all communities - executemany batch insert replaces per-community INSERT risk_index: 3 queries per node -> 3 total - single GROUP BY query for all caller counts - single SELECT for all tested qualified names - executemany batch insert replaces per-node INSERT On a repo with ~17k nodes and ~500 communities this reduces ~54,000 SQL round-trips to ~6, eliminating the build hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue fix: #243
Replace per-community and per-node query loops with precomputed aggregate queries + executemany batch inserts.
community_summaries: 2 queries per community -> 3 total
risk_index: 3 queries per node -> 3 total
On a repo with ~17k nodes and ~500 communities this reduces ~54,000 SQL round-trips to ~6, eliminating the build hang.