fix: CLI build/update/watch now run post-processing (signatures, FTS, flows, communities)#98
Conversation
|
I've put up a focused fix for this issue on my fork: igagankalra:fix/cli-post-processing (main...igagankalra:code-review-graph:fix/cli-post-processing)
|
tirth8205
left a comment
There was a problem hiding this comment.
Clean approach to the post-processing pipeline — extracting into a shared module and wiring into build/update/watch is the right design. 18 new tests.
Please rebase on latest main. This should merge before #95 (which overlaps on the post-processing piece).
… flows, communities) Extract the 4-step post-processing pipeline from tools/build.py into a shared postprocessing.py module and wire it into all CLI entry points so that `build`, `update`, and `watch` produce the same complete graph as the MCP tool. - Add code_review_graph/postprocessing.py with run_post_processing() - tools/build.py now delegates to run_post_processing() (no duplication) - cli.py calls _cli_post_process() after build and update commands - watch() accepts on_files_updated callback, invoked after each flush - 18 new tests covering all steps, isolation, idempotency, and watch Closes tirth8205#93
6880bb5 to
d66309f
Compare
|
@tirth8205 , Rebased the branch with main, should be good to be merged. |
Review: PR #98 — fix: CLI build/update/watch now run post-processingThis is a clean, focused fix. Extracting the 4-step post-processing pipeline into postprocessing.py is the right architectural move, and wiring it into build, update, and watch via an on_files_updated callback is correct. The author rebased on April 8 per the comments. Code review findings:
Merge order: Owner confirmed this should merge before #95. Both #94 (transaction fixes) and #98 (post-processing) are independently mergeable — however, #94's transaction fixes should ideally land first since they correct bugs in the code that post-processing calls (flows.py, communities.py, search.py). Verdict: Ready to merge after #94 lands and CI passes. Please confirm CI is green on the rebased branch. |
|
Update: Merge conflict detected. Despite the author's note that the branch was rebased on April 8, GitHub reports this PR has merge conflicts with main (mergeStateStatus: DIRTY). Please rebase again on the current main branch — there have likely been additional merges since April 8. Once conflicts are resolved and CI passes, this is ready to merge. |
Extract the 4-step post-processing pipeline from tools/build.py into a shared postprocessing.py module and wire it into all CLI entry points so that
build,update, andwatchproduce the same complete graph as the MCP tool.Closes #93